From 27a155c80a5cab62e625d9f49a313a8227f599ab Mon Sep 17 00:00:00 2001 From: shuoer86 <129674997+shuoer86@users.noreply.github.com> Date: Mon, 23 Oct 2023 18:30:57 +0800 Subject: [PATCH] MINOR: Fix typos in build.gradle, tests and trogdor (#14574) Reviewers: Mickael Maison , hudeqi <1217150961@qq.com> --- build.gradle | 2 +- tests/kafkatest/services/verifiable_client.py | 4 ++-- tests/kafkatest/tests/client/quota_test.py | 4 ++-- .../tests/streams/streams_broker_compatibility_test.py | 2 +- .../apache/kafka/trogdor/rest/RestExceptionMapperTest.java | 4 ++-- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/build.gradle b/build.gradle index 0cbcc063e66..c2d1938c1bd 100644 --- a/build.gradle +++ b/build.gradle @@ -774,7 +774,7 @@ def fineTuneEclipseClasspathFile(eclipse, project) { } /* * Set all eclipse build output to go to 'build_eclipse' directory. This is to ensure that gradle and eclipse use different - * build output directories, and also avoid using the eclpise default of 'bin' which clashes with some of our script directories. + * build output directories, and also avoid using the eclipse default of 'bin' which clashes with some of our script directories. * https://discuss.gradle.org/t/eclipse-generated-files-should-be-put-in-the-same-place-as-the-gradle-generated-files/6986/2 */ cp.entries.findAll { it.kind == "output" }*.path = "build_eclipse" diff --git a/tests/kafkatest/services/verifiable_client.py b/tests/kafkatest/services/verifiable_client.py index 5bd409e7984..649a428c37d 100644 --- a/tests/kafkatest/services/verifiable_client.py +++ b/tests/kafkatest/services/verifiable_client.py @@ -60,8 +60,8 @@ Common requirements for both: * Log/debug to stderr Common communication for both: - * `{ "name": "startup_complete" }` - Client succesfully started - * `{ "name": "shutdown_complete" }` - Client succesfully terminated (after receiving SIGINT/SIGTERM) + * `{ "name": "startup_complete" }` - Client successfully started + * `{ "name": "shutdown_complete" }` - Client successfully terminated (after receiving SIGINT/SIGTERM) ================== diff --git a/tests/kafkatest/tests/client/quota_test.py b/tests/kafkatest/tests/client/quota_test.py index 893bf75679a..08a23ecc4f6 100644 --- a/tests/kafkatest/tests/client/quota_test.py +++ b/tests/kafkatest/tests/client/quota_test.py @@ -77,10 +77,10 @@ class QuotaConfig(object): self.configure_quota(kafka, QuotaConfig.LARGE_QUOTA, QuotaConfig.LARGE_QUOTA, ['clients', None]) def configure_quota(self, kafka, producer_byte_rate, consumer_byte_rate, entity_args): - force_use_zk_conection = not kafka.all_nodes_configs_command_uses_bootstrap_server() + force_use_zk_connection = not kafka.all_nodes_configs_command_uses_bootstrap_server() node = kafka.nodes[0] cmd = "%s --alter --add-config producer_byte_rate=%d,consumer_byte_rate=%d" % \ - (kafka.kafka_configs_cmd_with_optional_security_settings(node, force_use_zk_conection), producer_byte_rate, consumer_byte_rate) + (kafka.kafka_configs_cmd_with_optional_security_settings(node, force_use_zk_connection), producer_byte_rate, consumer_byte_rate) cmd += " --entity-type " + entity_args[0] + self.entity_name_opt(entity_args[1]) if len(entity_args) > 2: cmd += " --entity-type " + entity_args[2] + self.entity_name_opt(entity_args[3]) diff --git a/tests/kafkatest/tests/streams/streams_broker_compatibility_test.py b/tests/kafkatest/tests/streams/streams_broker_compatibility_test.py index ab70b1d8269..f943c470541 100644 --- a/tests/kafkatest/tests/streams/streams_broker_compatibility_test.py +++ b/tests/kafkatest/tests/streams/streams_broker_compatibility_test.py @@ -195,7 +195,7 @@ class StreamsBrokerCompatibility(Test): processor.start() log.wait_until('Shutting down because the Kafka cluster seems to be on a too old version. Setting processing\.guarantee="exactly_once_v2"/"exactly_once_beta" requires broker version 2\.5 or higher\.', timeout_sec=60, - err_msg="Never saw 'Shutting down because the Kafka cluster seems to be on a too old version. Setting `processing.guarantee=\"exactly_once_v2\"/\"exaclty_once_beta\"` requires broker version 2.5 or higher.' log message " + str(processor.node.account)) + err_msg="Never saw 'Shutting down because the Kafka cluster seems to be on a too old version. Setting `processing.guarantee=\"exactly_once_v2\"/\"exactly_once_beta\"` requires broker version 2.5 or higher.' log message " + str(processor.node.account)) monitor.wait_until('FATAL: An unexpected exception org.apache.kafka.common.errors.UnsupportedVersionException', timeout_sec=60, err_msg="Never saw 'FATAL: An unexpected exception org.apache.kafka.common.errors.UnsupportedVersionException' error message " + str(processor.node.account)) diff --git a/trogdor/src/test/java/org/apache/kafka/trogdor/rest/RestExceptionMapperTest.java b/trogdor/src/test/java/org/apache/kafka/trogdor/rest/RestExceptionMapperTest.java index e61aec0165e..ed3d1ed34ca 100644 --- a/trogdor/src/test/java/org/apache/kafka/trogdor/rest/RestExceptionMapperTest.java +++ b/trogdor/src/test/java/org/apache/kafka/trogdor/rest/RestExceptionMapperTest.java @@ -80,7 +80,7 @@ public class RestExceptionMapperTest { @Test public void testToResponseUnknownException() { RestExceptionMapper mapper = new RestExceptionMapper(); - Response resp = mapper.toResponse(new Exception("Unkown exception")); + Response resp = mapper.toResponse(new Exception("Unknown exception")); assertEquals(resp.getStatus(), Response.Status.INTERNAL_SERVER_ERROR.getStatusCode()); } @@ -104,6 +104,6 @@ public class RestExceptionMapperTest { @Test public void testToExceptionRuntimeException() { - assertThrows(RuntimeException.class, () -> RestExceptionMapper.toException(-1, "Unkown status code")); + assertThrows(RuntimeException.class, () -> RestExceptionMapper.toException(-1, "Unknown status code")); } }