Browse Source

MINOR: Fix race condition in Streams EOS system test

We should start the process only within the `with` block, otherwise the bytes parameter would cause a race condition that result in false alarms of system test failures.

Author: Guozhang Wang <wangguoz@gmail.com>

Reviewers: Ewen Cheslack-Postava <me@ewencp.org>

Closes #4348 from guozhangwang/KMinor-fix-eos-test
pull/4348/merge
Guozhang Wang 7 years ago
parent
commit
7d6f6f7320
  1. 2
      tests/kafkatest/tests/streams/streams_eos_test.py

2
tests/kafkatest/tests/streams/streams_eos_test.py

@ -118,8 +118,8 @@ class StreamsEosTest(KafkaTest):
verifier.node.account.ssh("grep ALL-RECORDS-DELIVERED %s" % verifier.STDOUT_FILE, allow_fail=False) verifier.node.account.ssh("grep ALL-RECORDS-DELIVERED %s" % verifier.STDOUT_FILE, allow_fail=False)
def add_streams(self, processor): def add_streams(self, processor):
processor.start()
with processor.node.account.monitor_log(processor.STDOUT_FILE) as monitor: with processor.node.account.monitor_log(processor.STDOUT_FILE) as monitor:
processor.start()
self.wait_for_startup(monitor, processor) self.wait_for_startup(monitor, processor)
def add_streams2(self, running_processor, processor_to_be_started): def add_streams2(self, running_processor, processor_to_be_started):

Loading…
Cancel
Save