Browse Source
1. Permissions for mkdir set incorrectly, probably because it used incorrect python3 syntax (octals should use 0o prefix). 2. JAVA_HOME logic didn't seem to hold up to its promise. The original logic was broken when user input was empty. It was supposed to use JAVA_HOME system property to find java, but it wouldn't set jdk_java_home, so the following version check java_version = cmd_output("%s/bin/java -version" % jdk_java_home, env=jdk_env) would access /bin/java which does not exist on any system I know. Reviewer: Bruno Cadonna <cadonna@apache.org>pull/11373/head
Lucas Brutschy
2 years ago
committed by
GitHub
1 changed files with 4 additions and 3 deletions
Loading…
Reference in new issue