From c620b73883c675ef7c49cd87a5873b3f9da3a5e1 Mon Sep 17 00:00:00 2001 From: Stanislav Kozlovski Date: Wed, 9 Oct 2019 19:46:31 +0100 Subject: [PATCH] MINOR: Fix stale comment in partition reassignment javadoc (#7438) Reviewers: Colin P. McCabe , Viktor Somogyi --- core/src/main/scala/kafka/controller/KafkaController.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/main/scala/kafka/controller/KafkaController.scala b/core/src/main/scala/kafka/controller/KafkaController.scala index 642ebaa9934..e4679d3ae97 100644 --- a/core/src/main/scala/kafka/controller/KafkaController.scala +++ b/core/src/main/scala/kafka/controller/KafkaController.scala @@ -562,8 +562,8 @@ class KafkaController(val config: KafkaConfig, * . OVRS denotes the overlapping replica set - replicas which are part of the AR of the ongoing reassignment and will be part of the overriding reassignment * (it is essentially (RS - ORS) - URS) * - * 1 Set RS = ORS + OVRS, AR = OVRS, RS = [] in memory - * 2 Send LeaderAndIsr request with RS = ORS + OVRS, AR = [], RS = [] to all brokers in ORS + OVRS + * 1 Set RS = ORS + OVRS, AR = OVRS, RR = [] in memory + * 2 Send LeaderAndIsr request with RS = ORS + OVRS, AR = OVRS, RR = [] to all brokers in ORS + OVRS * (because the ongoing reassignment is in phase A, we know we wouldn't have a leader in URS * unless a preferred leader election was triggered while the reassignment was happening) * 3 Replicas in URS -> Offline (force those replicas out of ISR)