From f3a9ce4a69d17db7b8ba21134eb8118070176e48 Mon Sep 17 00:00:00 2001 From: Bruno Cadonna Date: Tue, 30 Jun 2020 19:18:23 +0200 Subject: [PATCH] MINOR: Do not swallow exception when collecting PIDs (#8914) During Streams' system tests the PIDs of the Streams clients are collected. The method the collects the PIDs swallows any exception that might be thrown by the ssh_capture() function. Swallowing any exceptions might make the investigation of failures harder, because no information about what happened are recorded. Reviewers: John Roesler --- tests/kafkatest/services/streams.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/kafkatest/services/streams.py b/tests/kafkatest/services/streams.py index 72847f63287..f7f8828b4cf 100644 --- a/tests/kafkatest/services/streams.py +++ b/tests/kafkatest/services/streams.py @@ -17,6 +17,7 @@ import os.path import signal import streams_property import consumer_property +from ducktape.cluster.remoteaccount import RemoteCommandError from ducktape.services.service import Service from ducktape.utils.util import wait_until from kafkatest.directory_layout.kafka_path import KafkaPathResolverMixin @@ -215,8 +216,10 @@ class StreamsTestBaseService(KafkaPathResolverMixin, JmxMixin, Service): def pids(self, node): try: - return [pid for pid in node.account.ssh_capture("cat " + self.PID_FILE, callback=int)] - except: + pids = [pid for pid in node.account.ssh_capture("cat " + self.PID_FILE, callback=str)] + return [int(pid) for pid in pids] + except Exception, exception: + self.logger.debug(str(exception)) return [] def stop_nodes(self, clean_shutdown=True):