Browse Source
I've seen this test fail with ``` java.lang.AssertionError: Throttled replication of 6352ms should be < 6000ms ``` A contributing factor is that it starts counting the time it took for replication before the replication itself has started. `createServer()` initializes ZK and other systems before it starts up the replication thread. I ran the test 25 times locally both ways. Average `throttledTook` before the change: 5341.75 Mean `throttledTook` after the change: 5256.92 Note that those are the results from `./gradlew core:test --tests kafka.server.ReplicationQuotasTest.shouldThrottleOldSegments`. I've noticed that if I run the whole test class `ReplicationQuotasTest`, the `throttledTook` is close ~4100. Reviewers: Ismael Juma <ismael@juma.me.uk>pull/5861/head
Stanislav Kozlovski
6 years ago
committed by
Ismael Juma
1 changed files with 2 additions and 2 deletions
Loading…
Reference in new issue