src-kafka

Commit Graph

Author	SHA1	Message	Date
Ismael Juma	39eb31feae	MINOR: Optimise performance of `Topic.validate()` I included a JMH benchmark and the results follow. The implementation in this PR takes no more than 1/10th of the time when compared to trunk. I also included results for an alternative implementation that is a little slower than the one in the PR. Trunk: ```text TopicBenchmark.testValidate topic avgt 15 134.107 ± 3.956 ns/op TopicBenchmark.testValidate longer-topic-name avgt 15 316.241 ± 13.379 ns/op TopicBenchmark.testValidate very-long-topic-name_with_more_text avgt 15 636.026 ± 30.272 ns/op ``` Implementation in the PR: ```text TopicBenchmark.testValidate topic avgt 15 13.153 ± 0.383 ns/op TopicBenchmark.testValidate longer-topic-name avgt 15 26.139 ± 0.896 ns/op TopicBenchmark.testValidate very-long-topic-name.with_more_text avgt 15 44.829 ± 1.390 ns/op ``` Alternative implementation where boolean validChar = Character.isLetterOrDigit(c) \|\| c == '.' \|\| c == '_' \|\| c == '-'; ```text TopicBenchmark.testValidate topic avgt 15 18.883 ± 1.044 ns/op TopicBenchmark.testValidate longer-topic-name avgt 15 36.696 ± 1.220 ns/op TopicBenchmark.testValidate very-long-topic-name_with_more_text avgt 15 65.956 ± 0.669 ns/op ``` Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Guozhang Wang <wangguoz@gmail.com> Closes #3234 from ijuma/optimise-topic-is-valid	8 years ago
Ismael Juma	c7bc8f7d8c	MINOR: Remove redundant volatile write in RecordHeaders The JMH benchmark included shows that the redundant volatile write causes the constructor of `ProducerRecord` to take more than 50% longer: ProducerRecordBenchmark.constructorBenchmark avgt 15 24.136 ± 1.458 ns/op (before) ProducerRecordBenchmark.constructorBenchmark avgt 15 14.904 ± 0.231 ns/op (after) Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Jason Gustafson <jason@confluent.io> Closes #3233 from ijuma/remove-volatile-write-in-records-header-constructor	8 years ago
Xavier Léauté	c060c48285	KAFKA-5150; Reduce LZ4 decompression overhead - reuse decompression buffers in consumer Fetcher - switch lz4 input stream to operate directly on ByteBuffers - avoids performance impact of catching exceptions when reaching the end of legacy record batches - more tests with both compressible / incompressible data, multiple blocks, and various other combinations to increase code coverage - fixes bug that would cause exception instead of invalid block size for invalid incompressible blocks - fixes bug if incompressible flag is set on end frame block size Overall this improves LZ4 decompression performance by up to 40x for small batches. Most improvements are seen for batches of size 1 with messages on the order of ~100B. We see at least 2x improvements for for batch sizes of < 10 messages, containing messages < 10kB This patch also yields 2-4x improvements on v1 small single message batches for other compression types. Full benchmark results can be found here https://gist.github.com/xvrl/05132e0643513df4adf842288be86efd Author: Xavier Léauté <xavier@confluent.io> Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Jason Gustafson <jason@confluent.io>, Ismael Juma <ismael@juma.me.uk> Closes #2967 from xvrl/kafka-5150	8 years ago
Amit Daga	8c872762f7	KAFKA-4996; Fix findBugs warning in getOrCreateSegment The code was correct since the method is only called from one thread, but the change is worthwhile anyway. Author: Amit Daga <adaga@adobe.com> Reviewers: Guozhang Wang <wangguoz@gmail.com>, Damian Guy <damian.guy@gmail.com>, Ismael Juma <ismael@juma.me.uk> Closes #2966 from amitdaga/findbugs-streams-multithread	8 years ago
Apurva Mehta	a82f194b21	KAFKA-4818; Exactly once transactional clients Author: Apurva Mehta <apurva@confluent.io> Reviewers: Guozhang Wang <wangguoz@gmail.com>, Ismael Juma <ismael@juma.me.uk>, Jason Gustafson <jason@confluent.io> Closes #2840 from apurvam/exactly-once-transactional-clients	8 years ago
Colin P. Mccabe	256f8d5662	KAFKA-5013; Fail the build when findbugs fails Author: Colin P. Mccabe <cmccabe@confluent.io> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes #2805 from cmccabe/KAFKA-5013	8 years ago
Colin P. Mccabe	ab148f39ae	KAFKA-4899; Fix findbugs warnings in kafka-core Author: Colin P. Mccabe <cmccabe@confluent.io> Reviewers: Jozef Koval <jozef.koval@protonmail.ch>, Ismael Juma <ismael@juma.me.uk> Closes #2687 from cmccabe/KAFKA-4899	8 years ago
Colin P. Mccabe	2f4f3b957d	KAFKA-4995; Fix remaining findbugs warnings in Kafka Streams Author: Colin P. Mccabe <cmccabe@confluent.io> Reviewers: Eno Thereska <eno@confluent.io>, Matthias J. Sax <matthias@confluent.io>, Ismael Juma <ismael@juma.me.uk> Closes #2780 from cmccabe/KAFKA-4995	8 years ago
Colin P. Mccabe	d5fb7364ae	KAFKA-4993; Fix findbugs warnings in kafka-clients Author: Colin P. Mccabe <cmccabe@confluent.io> Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>, Ismael Juma <ismael@juma.me.uk> Closes #2779 from cmccabe/KAFKA-4993	8 years ago
Colin P. Mccabe	f812a8fd93	KAFKA-4977: Fix findbugs issues in connect/runtime Author: Colin P. Mccabe <cmccabe@confluent.io> Reviewers: Konstantine Karantasis <konstantine@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io> Closes #2763 from cmccabe/KAFKA-4977	8 years ago
Colin P. Mccabe	7adf1e4148	KAFKA-4945; Suppress findbugs warnings about machine-generated code in jmh-benchmarks Author: Colin P. Mccabe <cmccabe@confluent.io> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes #2729 from cmccabe/KAFKA-4945	8 years ago
Colin P. Mccabe	a7e3679d22	KAFKA-4924: Fix Kafka Connect API findbugs warnings Author: Colin P. Mccabe <cmccabe@confluent.io> Reviewers: Ewen Cheslack-Postava <ewen@confluent.io> Closes #2715 from cmccabe/KAFKA-4924	8 years ago
Colin P. Mccabe	c9872cb214	KAFKA-4773; The Kafka build should run findbugs Author: Colin P. Mccabe <cmccabe@confluent.io> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes #2557 from cmccabe/KAFKA-4773	8 years ago

13 Commits (1fd70c7c94b20b82299ac1004e0ee01777b7beab)