Closes#719
This change adds the original Request Method to `RetryableException`,
allowing implementers to determine if a retry should occur based on
method and exception type.
To support this, `Response` objects now require that the original
`Request` be present. Test Cases, benchmarks, and documentation have
been added.
* Refactored Request Method Attribute on Requests
* Added `HttpMethod` enum that represents the supported HTTP methods
replacing String handling.
* Deprecated `Request#method()` in favor of `Request#httpMethod()`
* Creating headers from Request removing those with null or empty values
* Moving back to let the empty strings as valid header
* Returning headers filtering null and empty rather removing them for the current map. Supporting with tests as it needs to be LinkedHashMap not to lost the sorting
Fixes#665
When verifying that any of th `@*Map` annotations are in fact
`Map` instances, we were assumping that all values are direct
extension of a `Map` with generic type information intact. When
using frameworks like Spring, it is possible to have `Map` objects
that do not expose type information, like `HttpHeaders`, which
directly extend from a `Map` with the type information static.
This added additional checking to the `checkMapKeys` function
to accomodate for `Map` subclasses without type information. If
the map key information cannot be validated, we simply pass it
through.
* Added support for custom param encoding
* Added ability to inherit @CustomParam annotation
* Updated class cast style to match rest of code
* Updated to use QueryMap for custom pojo query parameters
* Clarification in README of QueryMap POJO usage
* Removed unused line
* Updated custom POJO QueryMap test to prove that private fields can be used
* Removed no-longer-valid test endpoint
* Renamed tests to more accurately reflect their contents
* More test cleanup
* Modified QueryMap POJO encoding to use specified QueryMapEncoder (default implementation provided)
* Corrected typo in README.md
* Fixed merge conflict and typo in test name
* Allows different collection encodings
In the case where a parameter represents a collection of values, there are
conflicting ways of encoding that collection. Common ways are repeating the
parameter name (foo=bar&foo=baz) and using comma separated values (foo=bar,baz).
The current behavior repeats the parameter name. This change introduces an
additional RequestLine parameter that explicitly specifies the encoding type,
one of CSV, TSV, space-delimited, pipe-delimited, and repeating the parameter
name. The default value for this option is repeating the parameter name, so
backwards compatibility is maintained.
* Replace switch statement with enum method for joining values
* Fixes retrials without Thread.sleep when thread gets interrupted
* Added test to verify if default retryer propagates RetryableException exception when thread is interrupted
* Add an option to not follow redirects (302) and add a unit test for that
* Implement followRedirect options for Ribbon Client and OkHTTP.
Add unit tests for these.
* Fix last failing unit test with IClientConfig options handling
* Using proper formatting pattern for logIOException.
Fixes#613
* Enforced rule exection order for LoggerTest such that ExpectedException is caught before the other rules. (The recording logging rule was ignored for tests that throw an exception). Fixed up test cases that never ran because of this. Added test for format character bug.
This commit adds the `doNotCloseAfterDecode` flag to the Feign builder object. This allows you to
lazily evaluate the response in your Decoder, in order to support Iterators or Java 8 Streams.
This is a pretty light weight change, to support a do-it-yourself approach to lazy instantiation.
Fixes#514.
* Avoid `Decoder.decode` on 404 when void response type
Avoid calling `decode` when receiving a 404 error and `decode404` is set and the response type is `void`.
* Update CHANGELOG
Kevin Davis
Marvin Froeder
fmcejudo
Marvin Herman Froeder
adriancole
Carter Kozak
Shadow Man
Benjamin Douglas
MichalSzewczyk
Guillaume
Jelte van der Hoek
Benjamin Shai
Bertrand Renuart
EthanLozano
Alan Loi
Odín del Río
Merkushev Kirill
Will May
Jin Zhang
Romain Gonord
rfalke
Dmitri Maximovich
Xavier Fornés
Pavlo
Andrey Stolyarchuk