A number of new changes introduced do not build on Windows
machines. This PR corrects the following issues:
* Java11 POM Parent
* BOM Plugin Template Paths for Windows and Unix/Linux/Mac
* SOAP Default encoding is now set to UTF-8 by default, not System default.
* No Longer prepend uri with slash if it is a query string
Fixes#887
Changes to target and uri parsing did not take into account
Empty Targets or URI provided methods. In these scenarios,
the target contains the entire path and the uri will be the
query string only. This change takes that into account and
no longer prepends a slash in these cases.
* Removed unnecessary import for Spring from Target Test
As part of 10.x, the `headers()` and `queries()` collections on the
`RequestTemplate` were made read only. The `JAXRSContract` was still
attempting to manipulate those directly. THis was missed due to a
use case not accounted for in the tests. I've added the appropriate
use case and corrected the usage of the template.
* Adding URI segment specific encoding
Fixes#879
URI encoding introduced in Feign 10.x was refactored to be more in line
with URI and URI Template specifications respectively. One change was to
ensure that certain reserved characters were not encoded incorrectly.
The result was that path segment specific reserved characters were being
preserved on the query string as well. This change updates the `UriTemplate`
and `Expression` classes to recognize the segment of the URI that is being processed
and apply the segment specific encoding correctly.
One important change regarding the `+` sign. Per the URI specification, a `+` sign
is allowed in both the path and query segments of a URI, however, handling of
the symbol on the query can be inconsistent. In some legacy systems, the `+` is
equivalent to the a space. Feign takes the approach of modern systems, where a
`+` symbol should not reprsent a space and is explicitly encoded as `%2B` when
found on a query string.
If you wish to use `+` as a space, then use the literal ` ` character or encode
the value directly as `%20`
Fixes#853
There are some scenarios reported where a server does
not provide headers with the response. While this is
not typically expected, it's simple enough for Feign to
be resilient to it. This change checks the headers provided
in the builder and if none are provided, an empty map is
used in it's place.
* Add support for java 8's Optional type to represent a HTTP 404 response.
* Delete x.patch
* Also dealing with Stream in case of empty responses
* Add support for java 8's Optional type to represent a HTTP 404 response.
* Delete x.patch
* Adding Support for Query Parameter Name Expansion
Fixes#838
`QueryTemplate` assumed that all query names were literals. This change
adds support for Expressions in Query Parameter names, providing better
adherence to RFC 6570.
RequestLines such as `@RequestLine("GET /uri?{parameter}={value}")` are
now fully expanded whereas before, only `{value}` would be.
* Adding Encoding and Resolution Enums for Template Control
These new enums replace the boolean values used to control
encoding and expression expansion options in Templates
* Allow unresolved expressions in Query Parameter Name and Body Template
Expressions in Query Parameter names and in a Body Template will
now no longer be removed if they are not resolved. For Query Template,
this change will prevent invalid query name/value pairs from being
generated.
For the Body Template, the documentation states that
unresolved should be preserved, yet the code did not match.
* NPE when resolving a template with binary body
* must cast to super class Buffer otherwise break when running with java 11
* Better error message for feign mock
* Recomend using Response.Builder on MockClient
* Throw cause of RetryableExceptions
* Allow propogation of underlying exceptions
Add configuration to Feign.Builder and support in SynchronousMethodHandler
to make it propagate the cause of RetryableExceptions
* Retab SMH
* Add note about propagation in readme
* Use enum for exception propagation policy
Adding support for Reactive Streams `Publisher` return types. Support
is provided through the `ReactiveInvocationHandler` and follows a similar
pattern used by `feign-hystrix`. Each method invocation is wrapped in a
`Callable`, which is then wrapped into the appropriate Reactive Streams
`Publisher`, as defined in the builder and the return type of the method.
This approach is not "reactive all the way down". The requests are still
executed via a regular `Client` and are synchronous. However, it is possible
to still take advantage of the backpressure, scheduling, and functional support
provided by the library implementations.
Limitations: Streams are not supported and Iterable responses are not treated
reactively. Iterables must be explicitly cast into a reactive type.
Reworked Builders and removed the need for the enumerator
* changed default query encoder result from POJO field to getter property
* changed default query encoder result from POJO field to getter property
* reset mistakenly deleted file
* Create PropertyQueryMapEncoder and extract QueryMapEncoder.Default to FieldQueryMapEncoder
* rename PropertyQueryMapEncoder to BeanQueryMapEncoder and add README
* fix README
* add comments to QueryMapEncoder and remove deprecation on Default
* rename test name
* rename package name queryMap to querymap
* format code