* Fix for #1286
When feign is done with the response, also invoke close on http response (if closeable)
* Update httpclient/src/main/java/feign/httpclient/ApacheHttpClient.java
Co-authored-by: Austin Pio <austinpioj@gmail.com>
* Update ApacheHttpClient.java
* Use finally block to close http5 client
* Use finally block to close http5 client
Co-authored-by: Kevin Davis <kdavisk6@gmail.com>
Co-authored-by: Austin Pio <austinpioj@gmail.com>
* Upgrade httpclient5 to GA version 5.0.3
* Updating License Headers for 2021
Co-authored-by: Thanh Nguyen <thanh.nguyen-ky@klarna.com>
Co-authored-by: Davis, Kevin <kdavisk6@gmail.com>
Fixes: #934, #1208
This change updates the Input Stream handling when using the Default
client implementation to detect when a response is `gzipped` and
wrap it in a `GZipInputStream`.
This addresses any issues related to compression when using the
default client.
In addition, removed the implicit parsing of the
body during toString. This was also brought up in #1208 and it came up
during testing of this change. Users should be using our `asReader`
and other methods to access the response body.
* Adding Deflate support
* Added Deflate Support and removed implicit response body reading
* Refactored Gzip and Deflate Conditions
* Corrected formatting and line-endings
Fixes#1163
Restores `Request.Body.encoded` static function and
`RequestTemplate.requestBody` to restore compatibility.
Additionally, mark it as deprecated to encourage usage of
`RequestTemplate.body`.
`Request.Body` is an internal abstraction that was made built
in an effort to better manage request body data. It was made
public too early and will be reverted back to it's internal
state in future releases.
Fixes#1156
Collection Format was encoding query string values unnecessarily
due to changes introduced in #1138 and #1139 that encode template
values before appending them to the query string.
In addition, `decodeSlash` flags that were accidentally removed,
have been restored in QueryTemplate.
* Restoring decodeSlash in QueryTemplate
* Correcting Readme with regards to decodeSlash usage
Fixes#857
To simply removal, Request.Body was returned back to an internal
component and additional methods were added to Request to expose
it's capabilities outside of the object.
All other deprecated usage in core modules has been removed.
Deprecated code still exists in the test cases and will be
removed once the deprecated methods are removed in our next
major release.