Fixes#697
This change replaces JCenter with Sonatype OSSRH for snapshot and
release management. To complete this change, we will need to add
additional information to Travis, specifically the GPG information
to sign the artifacts during a release.
It's my opinion that those values should be in Travis directly and
not here in this repository. I'm open to other suggestions and
feedback on this approach.
Additional changes include:
* Updating BOM template to include SCM per OSSRH rules.
* Removed Bintray and GitHub credentials, they are no longer needed.
* Adding GPG Signing Values
* Code Signing Paths
rfc7231 section 7.1.3 states that the Retry-After header can return delay-seconds value
that is a non-negative decimal integer, representing time in seconds.
Some servers return the second delay with a decimal point. Eg instead of 2 they return 2.0
This patch handles this case where the server has included a decimal point in their response.
* This pr resolves issue #927
add apache commons lang3 as mvn dependency to get inherited fields of given class
change type.getDeclaredFields() to FieldUtils.getAllFieldsList(type) on FieldQueryMapEncoder
* format
* remove apache common langs dependency
add logic for finding fields which comes via inheritance
Simplified the `travis` configuration back to it's minimal form to create
a new starting point.
* Adding Explicit Deploy stage
* Updating documentation and adding tagging to the release script
* Adding tag configuration to pom
* Configured Travis to Skip the commits created when preparing the release
* Adding Git Credentials
* Added Sync Stage during releases
In this pr the old `body()` method calls replaced with `requestBody().asBytes()` method which both exists in Request class. The intention is to remove deprecated code and keep source code clean.
Related to #857
* replaced old body with new Body.asBytes()
* add HeaderTemplate create tests for fail
* - added expand test
* - remove redundant public static identifier from Retryer inner class
* - remove redundant public static identifier from Default inner class
* add license to test
* mvn clean install to format test file
* Updated Expression Patterns to allow brackets
Fixes#928
Relaxed the regular expression that is used to determine if a given
value is an Expression per the URI Template Spec RFC 6570. We already
deviated by allowing dashes to exist without pct-encoding, this change
adds braces `[]` to this list.
Also included is the ability to set Collection Format per Query, overriding
the Template default. This allows for mixed Collection formats in the
same template and provides a way for Contract extensions to determine
which expansion type they want when parsing a contract.
* Fixing Formatting
Replaced comma with Constant Delimiter in Template
Fixes#924
Commas were used to identify iterable content, which conflicted when
a comma delimited literal was provided during expansion. This change
switches commas for semi-colons, which are considered reserved secondary
delimiters in RFC 6750 and should not be used without being pct-encoded.
Should be a safer choice.
Removed decoding from Body Template Expansion
Fixes#916
In certain cases, a Body Template will contain a JSON payload. To
support this we are asking users to pct-encode the beginning and the
end of the JSON object when providing it to the RequestLine so we don't
reject it as an expression. Doing this requires that the we decode those
markers before submitting the request.
This change updates that logic to only decode the first and last characters
only and not decode the entire payload, since Body values don't require
any type of encoding.
Fixes NullPointerException when accessing a FeignException's content
Fixes#912
If the content of a FeignException is null, `contentUTF8()` now returns an empty string rather than throwing a NullPointerException.
Fixes#872
Previously, all unresolved query template expressions resolved
to empty strings, which then indcate that the entire query parameter
should be removed. This violates RFC 6570 in that only undefined
values should be removed. This change updates Query Template to
check the provided `variables` map for an entry expression. If
no value is provided, the entry is explicitly marked `UNDEF` and
removed.
This brings us in line with the specification. The following is
now how parameters are resolved:
*Empty String*
```java
public void test() {
Map<String, Object> parameters = new LinkedHashMap<>();
parameters.put("param", "");
this.demoClient.test(parameters);
}
```
Result
```
http://localhost:8080/test?param=
```
*Missing*
```java
public void test() {
Map<String, Object> parameters = new LinkedHashMap<>();
this.demoClient.test(parameters);
}
```
Result
```
http://localhost:8080/test
```
*Undefined*
```java
public void test() {
Map<String, Object> parameters = new LinkedHashMap<>();
parameters.put("param", null);
this.demoClient.test(parameters);
}
```
Result
```
http://localhost:8080/test
```
* Adding additional test case for explicit null parameter value
* Additional Test case for the explict `null` case. Updates to the
documentation.
A number of new changes introduced do not build on Windows
machines. This PR corrects the following issues:
* Java11 POM Parent
* BOM Plugin Template Paths for Windows and Unix/Linux/Mac
* SOAP Default encoding is now set to UTF-8 by default, not System default.
* No Longer prepend uri with slash if it is a query string
Fixes#887
Changes to target and uri parsing did not take into account
Empty Targets or URI provided methods. In these scenarios,
the target contains the entire path and the uri will be the
query string only. This change takes that into account and
no longer prepends a slash in these cases.
* Removed unnecessary import for Spring from Target Test
As part of 10.x, the `headers()` and `queries()` collections on the
`RequestTemplate` were made read only. The `JAXRSContract` was still
attempting to manipulate those directly. THis was missed due to a
use case not accounted for in the tests. I've added the appropriate
use case and corrected the usage of the template.
* Adding URI segment specific encoding
Fixes#879
URI encoding introduced in Feign 10.x was refactored to be more in line
with URI and URI Template specifications respectively. One change was to
ensure that certain reserved characters were not encoded incorrectly.
The result was that path segment specific reserved characters were being
preserved on the query string as well. This change updates the `UriTemplate`
and `Expression` classes to recognize the segment of the URI that is being processed
and apply the segment specific encoding correctly.
One important change regarding the `+` sign. Per the URI specification, a `+` sign
is allowed in both the path and query segments of a URI, however, handling of
the symbol on the query can be inconsistent. In some legacy systems, the `+` is
equivalent to the a space. Feign takes the approach of modern systems, where a
`+` symbol should not reprsent a space and is explicitly encoded as `%2B` when
found on a query string.
If you wish to use `+` as a space, then use the literal ` ` character or encode
the value directly as `%20`
jerzykrlk
Kevin Davis
Richard Wallis
Emre Savcı
Snyk bot
Snyk bot
Marvin Froeder
尹吉峰
Matthew Hall
rejierd
Whitilied
Roman Bachmann
Paul Aly
Dmitry Matveev