From ff054309ecf04f5e049b40533cd2dedabf38d0aa Mon Sep 17 00:00:00 2001 From: Denis Zavedeev Date: Sat, 30 Nov 2019 13:34:41 +0300 Subject: [PATCH] Fix some typos in documentation In particular: - add missing `new` operator - ensure that `RouteDefinitionLocators` is properly formatted in the "Configuration" section - "Normwal" -> "Normal" - remove extra "`" --- docs/src/main/asciidoc/spring-cloud-gateway.adoc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/src/main/asciidoc/spring-cloud-gateway.adoc b/docs/src/main/asciidoc/spring-cloud-gateway.adoc index bd6d47b7a..41a297361 100644 --- a/docs/src/main/asciidoc/spring-cloud-gateway.adoc +++ b/docs/src/main/asciidoc/spring-cloud-gateway.adoc @@ -1226,7 +1226,7 @@ As Spring Cloud Gateway distinguishes between "pre" and "post" phases for filter ---- @Bean public GlobalFilter customFilter() { - return CustomGlobalFilter(); + return new CustomGlobalFilter(); } public class CustomGlobalFilter implements GlobalFilter, Ordered { @@ -1324,7 +1324,7 @@ The `NettyWriteResponseFilter` runs if there is a Netty `HttpClientResponse` in === RouteToRequestUrl Filter -The `RouteToRequestUrlFilter` runs if there is a `Route` object in the `ServerWebExchangeUtils.GATEWAY_ROUTE_ATTR` exchange attribute. It creates a new URI, based off of the request URI, but updated with the URI attribute of the `Route` object. The new URI is placed in the `ServerWebExchangeUtils.GATEWAY_REQUEST_URL_ATTR` exchange attribute`. +The `RouteToRequestUrlFilter` runs if there is a `Route` object in the `ServerWebExchangeUtils.GATEWAY_ROUTE_ATTR` exchange attribute. It creates a new URI, based off of the request URI, but updated with the URI attribute of the `Route` object. The new URI is placed in the `ServerWebExchangeUtils.GATEWAY_REQUEST_URL_ATTR` exchange attribute. If the URI has a scheme prefix, such as `lb:ws://serviceid`, the `lb` scheme is stripped from the URI and placed in the `ServerWebExchangeUtils.GATEWAY_SCHEME_PREFIX_ATTR` for use later in the filter chain. @@ -1348,7 +1348,7 @@ spring: uri: http://localhost:3001 predicates: - Path=/websocket/info/** - # Normwal Websocket route + # Normal Websocket route - id: websocket_route uri: ws://localhost:3001 predicates: @@ -1444,7 +1444,7 @@ spring: == Configuration -Configuration for Spring Cloud Gateway is driven by a collection of `RouteDefinitionLocator`s. +Configuration for Spring Cloud Gateway is driven by a collection of ``RouteDefinitionLocator``s. .RouteDefinitionLocator.java [source,java]