From 2573a543b260297b29fb3b365200ea943a0cd0cc Mon Sep 17 00:00:00 2001 From: Allon Mureinik Date: Tue, 12 Jun 2018 11:52:03 +0300 Subject: [PATCH] SPR-16936 Fix PathVariable javadoc @PathVariable's javadoc states that it supports MultiValueMap parameters (introduced by commit df0902), but by reading through the code, that does not seem to be the case (compare, e.g., PathVariableMapMethodArgumentResolver to RequestParamMapMethodArgumentResolver). Moreover, parsing MultipleValueMap is done according to the ";" character, and placing such a character in a path (e.g., consider something like "/app/{param}/show" would just break the path. This patch fixes PathVariable's javadoc by removing the mention of MultiValueMap. --- .../org/springframework/web/bind/annotation/PathVariable.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/spring-web/src/main/java/org/springframework/web/bind/annotation/PathVariable.java b/spring-web/src/main/java/org/springframework/web/bind/annotation/PathVariable.java index d07619f76b..7485e10d96 100644 --- a/spring-web/src/main/java/org/springframework/web/bind/annotation/PathVariable.java +++ b/spring-web/src/main/java/org/springframework/web/bind/annotation/PathVariable.java @@ -29,8 +29,7 @@ import org.springframework.core.annotation.AliasFor; * variable. Supported for {@link RequestMapping} annotated handler methods in Servlet * environments. * - *

If the method parameter is {@link java.util.Map Map<String, String>} or - * {@link org.springframework.util.MultiValueMap MultiValueMap<String, String>} + *

If the method parameter is {@link java.util.Map Map<String, String>} * then the map is populated with all path variable names and values. * * @author Arjen Poutsma