From 420f8237c013b956dd572283ea97c9014f526960 Mon Sep 17 00:00:00 2001 From: Oliver Gierke Date: Tue, 15 Jun 2010 05:33:39 +0000 Subject: [PATCH] Rollback accidental commit :/. --- .../core/annotation/AnnotationUtils.java | 200 ------------------ .../core/annotation/AnnotationUtilsTests.java | 60 +----- 2 files changed, 1 insertion(+), 259 deletions(-) diff --git a/org.springframework.core/src/main/java/org/springframework/core/annotation/AnnotationUtils.java b/org.springframework.core/src/main/java/org/springframework/core/annotation/AnnotationUtils.java index 4f0ac7fb42..dc86282376 100644 --- a/org.springframework.core/src/main/java/org/springframework/core/annotation/AnnotationUtils.java +++ b/org.springframework.core/src/main/java/org/springframework/core/annotation/AnnotationUtils.java @@ -18,10 +18,8 @@ package org.springframework.core.annotation; import java.lang.annotation.Annotation; import java.lang.reflect.Method; -import java.util.ArrayList; import java.util.Arrays; import java.util.HashMap; -import java.util.List; import java.util.Map; import org.springframework.core.BridgeMethodResolver; @@ -43,7 +41,6 @@ import org.springframework.util.Assert; * @author Juergen Hoeller * @author Sam Brannen * @author Mark Fisher - * @author Oliver Gierke * @since 2.0 * @see java.lang.reflect.Method#getAnnotations() * @see java.lang.reflect.Method#getAnnotation(Class) @@ -376,201 +373,4 @@ public abstract class AnnotationUtils { } } - /** - * Returns a {@link ParameterAnnotation} instance for the first parameter with the given annotation. - * @param - * @param method the {@link Method} whose parameters shall be inspected - * @param annotationType the annotation typed the parameter shall carry - * @return - */ - public static ParameterAnnotation getParameterAnnotation(Method method, - Class annotationType) { - - List> annotations = getParameterAnnotations(method, annotationType); - return annotations.isEmpty() ? null : annotations.get(0); - } - - /** - * Returns all {@link ParameterAnnotation}s for parameters with the given annotation. - * @param - * @param method the {@link Method} whose parameters shall be scanned for annotations - * @param annotationType the annotation type the paramter shall carry - * @return - */ - public static List> getParameterAnnotations(Method method, - Class annotationType) { - - return getParameterAnnotations(method, new AnnotationTypeFilter(annotationType)); - } - - /** - * Returns the {@link ParameterAnnotation} for a parameter of the given type that carries an annotation of the given - * type. - * @param - * @param method the {@link Method} that shall be scanned for parameters carrying the annotation - * @param annotationType the annotation type that shall be discovered - * @param parameterType the parameter type that shall be considered - * @return - */ - public static ParameterAnnotation getParameterAnnotation(Method method, - Class annotationType, final Class parameterType) { - - List> annotations = getParameterAnnotations(method, annotationType, parameterType); - return annotations.isEmpty() ? null : annotations.get(0); - } - - /** - * Returns all {@link ParameterAnnotation}s for parameters of the given type that carry an annotation of the given - * type. - * @param - * @param method the {@link Method} that shall be scanned for parameters carrying the annotation - * @param annotationType the annotation type that shall be discovered - * @param parameterType the parameter type that shall be considered - * @return - */ - public static List> getParameterAnnotations(Method method, - Class annotationType, final Class parameterType) { - - return getParameterAnnotations(method, new AnnotationTypeFilter(annotationType) { - - @Override - public boolean matches(ParameterAnnotation parameterAnnotation) { - return super.matches(parameterAnnotation) - && parameterType.equals(parameterAnnotation.getParameterType()); - } - }); - } - - /** - * Returns all {@link ParameterAnnotation}s for parameters of the given method that match the given - * {@link ParameterAnnotationFilter}. - * @see ParameterAnnotationFilter - * @param - * @param method the {@link Method} that shall be scanned for annotated parameters - * @param filter a {@link ParameterAnnotationFilter} to apply criterias on the {@link ParameterAnnotation}s to be - * returned - * @return - */ - @SuppressWarnings("unchecked") - public static List> getParameterAnnotations(Method method, - ParameterAnnotationFilter filter) { - - List> result = new ArrayList>(); - - Annotation[][] parameterAnnotations = method.getParameterAnnotations(); - Class[] parameterTypes = method.getParameterTypes(); - - for (int i = 0; i < parameterAnnotations.length; i++) { - for (Annotation annotation : parameterAnnotations[i]) { - - ParameterAnnotation parameterAnnotation = new ParameterAnnotation((T) annotation, i, - parameterTypes[i]); - - if (filter.matches(parameterAnnotation)) { - result.add(parameterAnnotation); - } - } - } - - return result; - } - - /** - * Allows filtering {@link ParameterAnnotation} instances. - * @see AnnotationUtils#getParameterAnnotations(Method, ParameterAnnotationFilter) - */ - public interface ParameterAnnotationFilter { - boolean matches(ParameterAnnotation annotation); - } - - /** - * {@link ParameterAnnotationFilter} that matches all {@link ParameterAnnotation}s that have the given annotation - * type. - */ - public static class AnnotationTypeFilter implements ParameterAnnotationFilter { - - private final Class annotationType; - - public AnnotationTypeFilter(Class annotationType) { - this.annotationType = annotationType; - } - - public boolean matches(ParameterAnnotation parameterAnnotation) { - return annotationType.equals(parameterAnnotation.getAnnotation().annotationType()); - } - } - - /** - * Captures an annotation for a method parameter as well as some meta information about the parameter. - */ - public static class ParameterAnnotation { - - private final T annotation; - private final int parameterIndex; - private final Class parameterType; - - ParameterAnnotation(T annotation, int parameterIndex, Class parameterType) { - Assert.notNull(annotation); - Assert.notNull(parameterType); - this.annotation = annotation; - this.parameterIndex = parameterIndex; - this.parameterType = parameterType; - } - - /** - * Returns the annotation bound to the parameter. - * @return the annotation - */ - public T getAnnotation() { - return annotation; - } - - /** - * Returns the method parameter index in the list of parameters. - * @return the parameterIndex - */ - public int getParameterIndex() { - return parameterIndex; - } - - /** - * Returns the type of the method parameter the annotation is bound to. - * @return the parameterType - */ - public Class getParameterType() { - return parameterType; - } - - /* - * (non-Javadoc) - * - * @see java.lang.Object#equals(java.lang.Object) - */ - @Override - public boolean equals(Object obj) { - if (obj == this) { - return true; - } - if (!(obj instanceof ParameterAnnotation)) { - return false; - } - - ParameterAnnotation that = (ParameterAnnotation) obj; - return this.annotation.equals(that.annotation) && this.parameterType.equals(that.parameterType) - && this.parameterIndex == that.parameterIndex; - } - - /* - * (non-Javadoc) - * - * @see java.lang.Object#hashCode() - */ - @Override - public int hashCode() { - int result = 17; - result = 31 * result + annotation.hashCode(); - result = 31 * result + parameterType.hashCode(); - return 31 * result + (parameterIndex ^ parameterIndex >>> 32); - } - } } diff --git a/org.springframework.core/src/test/java/org/springframework/core/annotation/AnnotationUtilsTests.java b/org.springframework.core/src/test/java/org/springframework/core/annotation/AnnotationUtilsTests.java index d1f0ead0a4..e131c72f3c 100644 --- a/org.springframework.core/src/test/java/org/springframework/core/annotation/AnnotationUtilsTests.java +++ b/org.springframework.core/src/test/java/org/springframework/core/annotation/AnnotationUtilsTests.java @@ -19,18 +19,13 @@ package org.springframework.core.annotation; import static org.junit.Assert.*; import static org.springframework.core.annotation.AnnotationUtils.*; -import java.io.Serializable; -import java.lang.annotation.ElementType; import java.lang.annotation.Inherited; import java.lang.annotation.Retention; import java.lang.annotation.RetentionPolicy; -import java.lang.annotation.Target; import java.lang.reflect.Method; -import java.util.List; import org.junit.Test; import org.springframework.core.Ordered; -import org.springframework.core.annotation.AnnotationUtils.ParameterAnnotation; /** * @author Rod Johnson @@ -209,45 +204,6 @@ public class AnnotationUtilsTests { assertNotNull(order); } - @Test - public void testDetectsParameterAnnotation() throws Exception { - - Method method = InterfaceWithAnnotatedMethodParameters.class.getMethod("foo", String.class, Long.class); - ParameterAnnotation parameterAnnotation = getParameterAnnotation(method, MyAnnotation.class); - assertParameterAnnotationWith(parameterAnnotation, "foo", 1, Long.class); - - List> parameterAnnotations = getParameterAnnotations(method, - MyAnnotation.class); - assertNotNull(parameterAnnotations); - assertEquals(1, parameterAnnotations.size()); - assertEquals(parameterAnnotation, parameterAnnotations.get(0)); - } - - @Test - public void testDetectsFirstParameterAnnotationForMultipleOnes() throws Exception { - - Method method = InterfaceWithAnnotatedMethodParameters.class.getMethod("bar", String.class, String.class, - Serializable.class); - ParameterAnnotation parameterAnnotation = getParameterAnnotation(method, MyAnnotation.class); - assertParameterAnnotationWith(parameterAnnotation, "first", 0, String.class); - - List> parameterAnnotations = getParameterAnnotations(method, - MyAnnotation.class); - assertNotNull(parameterAnnotations); - assertEquals(2, parameterAnnotations.size()); - assertEquals(parameterAnnotation, parameterAnnotations.get(0)); - assertParameterAnnotationWith(parameterAnnotations.get(1), "third", 2, Serializable.class); - } - - private void assertParameterAnnotationWith(ParameterAnnotation parameterAnnotation, String value, - int index, Class parameterType) { - assertNotNull(parameterAnnotation); - assertEquals(index, parameterAnnotation.getParameterIndex()); - assertNotNull(parameterAnnotation.getAnnotation()); - assertEquals(value, parameterAnnotation.getAnnotation().value()); - assertEquals(parameterType, parameterAnnotation.getParameterType()); - } - public static interface AnnotatedInterface { @Order(0) @@ -365,24 +321,10 @@ public class AnnotationUtilsTests { } } - public static interface InterfaceWithAnnotatedMethodParameters { - - void foo(String foo, @MyAnnotation("foo") Long bar); - - void bar(@MyAnnotation("first") String first, String second, - @Transactional @MyAnnotation("third") Serializable third); - } } @Retention(RetentionPolicy.RUNTIME) @Inherited @interface Transactional { - -} - -@Retention(RetentionPolicy.RUNTIME) -@Target(ElementType.PARAMETER) -@interface MyAnnotation { - - String value() default ""; + }