Browse Source

Revise Testcontainers examples based on feedback

Closes gh-29939
pull/29946/head
Sam Brannen 2 years ago
parent
commit
482482f62b
  1. 6
      framework-docs/src/docs/asciidoc/testing/testcontext-framework.adoc
  2. 3
      spring-test/src/main/java/org/springframework/test/context/DynamicPropertySource.java

6
framework-docs/src/docs/asciidoc/testing/testcontext-framework.adoc

@ -2023,8 +2023,7 @@ properties. @@ -2023,8 +2023,7 @@ properties.
@Container
static GenericContainer redis =
new GenericContainer(DockerImageName.parse("redis:5.0.3-alpine"))
.withExposedPorts(6379);
new GenericContainer("redis:5.0.3-alpine").withExposedPorts(6379);
@DynamicPropertySource
static void redisProperties(DynamicPropertyRegistry registry) {
@ -2048,8 +2047,7 @@ properties. @@ -2048,8 +2047,7 @@ properties.
@Container
@JvmStatic
val redis: GenericContainer =
GenericContainer(DockerImageName.parse("redis:5.0.3-alpine"))
.withExposedPorts(6379)
GenericContainer("redis:5.0.3-alpine").withExposedPorts(6379)
@DynamicPropertySource
@JvmStatic

3
spring-test/src/main/java/org/springframework/test/context/DynamicPropertySource.java

@ -71,8 +71,7 @@ import java.lang.annotation.Target; @@ -71,8 +71,7 @@ import java.lang.annotation.Target;
*
* @Container
* static GenericContainer redis =
* new GenericContainer(DockerImageName.parse("redis:5.0.3-alpine"))
* .withExposedPorts(6379);
* new GenericContainer("redis:5.0.3-alpine").withExposedPorts(6379);
*
* // ...
*

Loading…
Cancel
Save