Browse Source

fixing TODOs

conversation
Andy Clement 17 years ago
parent
commit
5a68d0ee4e
  1. 2
      org.springframework.expression/src/main/java/org/springframework/expression/spel/standard/StandardEvaluationContext.java
  2. 4
      org.springframework.expression/src/main/java/org/springframework/expression/spel/standard/StandardTypeConverter.java

2
org.springframework.expression/src/main/java/org/springframework/expression/spel/standard/StandardEvaluationContext.java

@ -170,7 +170,7 @@ public class StandardEvaluationContext implements EvaluationContext { @@ -170,7 +170,7 @@ public class StandardEvaluationContext implements EvaluationContext {
rootObject = o;
}
// TODO 3 have a variant that adds at position (same for ctor/propOrField)
// TODO have a variant that adds at position (same for ctor/propOrField)
public void addMethodResolver(MethodResolver resolver) {
methodResolvers.add(resolver);
}

4
org.springframework.expression/src/main/java/org/springframework/expression/spel/standard/StandardTypeConverter.java

@ -93,7 +93,7 @@ public class StandardTypeConverter implements TypeConverter { @@ -93,7 +93,7 @@ public class StandardTypeConverter implements TypeConverter {
return false;
}
// TODO 3 Q In case of a loss in information with coercion to a narrower type, should we throw an exception?
// TODO In case of a loss in information with coercion to a narrower type, should we throw an exception?
public Object convertValue(Object value, Class<?> targetType) throws SpelException {
if (value == null || value.getClass() == targetType)
return value;
@ -201,7 +201,7 @@ public class StandardTypeConverter implements TypeConverter { @@ -201,7 +201,7 @@ public class StandardTypeConverter implements TypeConverter {
try {
Double.parseDouble((String) value);
} catch (NumberFormatException nfe) {
// TODO 3 Q throw something or leave the caller to throw a conversion exception?
// returning null will mean the caller throws a type conversion related exception
}
} else if (value instanceof Integer) {
return new Double(((Integer) value).intValue());

Loading…
Cancel
Save