Browse Source

Polish "Deprecate support for theme" changes

See gh-29202
pull/29208/head
Johnny Lim 2 years ago committed by Stephane Nicoll
parent
commit
907c96b21e
  1. 2
      spring-web/src/main/java/org/springframework/web/context/support/AbstractRefreshableWebApplicationContext.java
  2. 2
      spring-web/src/main/java/org/springframework/web/context/support/GenericWebApplicationContext.java
  3. 2
      spring-web/src/main/java/org/springframework/web/context/support/StaticWebApplicationContext.java
  4. 7
      spring-webmvc/src/main/java/org/springframework/web/servlet/DispatcherServlet.java
  5. 9
      spring-webmvc/src/main/java/org/springframework/web/servlet/support/RequestContext.java
  6. 1
      spring-webmvc/src/test/java/org/springframework/web/servlet/config/annotation/InterceptorRegistryTests.java

2
spring-web/src/main/java/org/springframework/web/context/support/AbstractRefreshableWebApplicationContext.java

@ -57,7 +57,7 @@ import org.springframework.web.context.ServletContextAware;
* {@link org.springframework.context.support.AbstractApplicationContext}, * {@link org.springframework.context.support.AbstractApplicationContext},
* this class detects a bean of type {@link org.springframework.ui.context.ThemeSource} * this class detects a bean of type {@link org.springframework.ui.context.ThemeSource}
* in the context, under the special bean name "themeSource". * in the context, under the special bean name "themeSource".
* Theme support is deprecated as of 6.0 * Theme support is deprecated as of 6.0 with no direct replacement.
* *
* <p><b>This is the web context to be subclassed for a different bean definition format.</b> * <p><b>This is the web context to be subclassed for a different bean definition format.</b>
* Such a context implementation can be specified as "contextClass" context-param * Such a context implementation can be specified as "contextClass" context-param

2
spring-web/src/main/java/org/springframework/web/context/support/GenericWebApplicationContext.java

@ -52,7 +52,7 @@ import org.springframework.web.context.ServletContextAware;
* <p>In addition to the special beans detected by * <p>In addition to the special beans detected by
* {@link org.springframework.context.support.AbstractApplicationContext AbstractApplicationContext}, * {@link org.springframework.context.support.AbstractApplicationContext AbstractApplicationContext},
* this class detects a {@link ThemeSource} bean in the context, with the name "themeSource". * this class detects a {@link ThemeSource} bean in the context, with the name "themeSource".
* Theme support is deprecated as of 6.0 * Theme support is deprecated as of 6.0 with no direct replacement.
* *
* <p>If you wish to register annotated <em>component classes</em> with a * <p>If you wish to register annotated <em>component classes</em> with a
* {@code GenericWebApplicationContext}, you can use an * {@code GenericWebApplicationContext}, you can use an

2
spring-web/src/main/java/org/springframework/web/context/support/StaticWebApplicationContext.java

@ -50,7 +50,7 @@ import org.springframework.web.context.ServletContextAware;
* {@link org.springframework.context.support.AbstractApplicationContext}, * {@link org.springframework.context.support.AbstractApplicationContext},
* this class detects a bean of type {@link org.springframework.ui.context.ThemeSource} * this class detects a bean of type {@link org.springframework.ui.context.ThemeSource}
* in the context, under the special bean name "themeSource". * in the context, under the special bean name "themeSource".
* Theme support is deprecated as of 6.0 * Theme support is deprecated as of 6.0 with no direct replacement.
* *
* @author Rod Johnson * @author Rod Johnson
* @author Juergen Hoeller * @author Juergen Hoeller

7
spring-webmvc/src/main/java/org/springframework/web/servlet/DispatcherServlet.java

@ -169,7 +169,10 @@ public class DispatcherServlet extends FrameworkServlet {
/** Well-known name for the LocaleResolver object in the bean factory for this namespace. */ /** Well-known name for the LocaleResolver object in the bean factory for this namespace. */
public static final String LOCALE_RESOLVER_BEAN_NAME = "localeResolver"; public static final String LOCALE_RESOLVER_BEAN_NAME = "localeResolver";
/** Well-known name for the ThemeResolver object in the bean factory for this namespace. */ /**
* Well-known name for the ThemeResolver object in the bean factory for this namespace.
* @deprecated as of 6.0, with no direct replacement
*/
@Deprecated @Deprecated
public static final String THEME_RESOLVER_BEAN_NAME = "themeResolver"; public static final String THEME_RESOLVER_BEAN_NAME = "themeResolver";
@ -227,6 +230,7 @@ public class DispatcherServlet extends FrameworkServlet {
/** /**
* Request attribute to hold the current ThemeResolver, retrievable by views. * Request attribute to hold the current ThemeResolver, retrievable by views.
* @see org.springframework.web.servlet.support.RequestContextUtils#getThemeResolver * @see org.springframework.web.servlet.support.RequestContextUtils#getThemeResolver
* @deprecated as of 6.0, with no direct replacement
*/ */
@Deprecated @Deprecated
public static final String THEME_RESOLVER_ATTRIBUTE = DispatcherServlet.class.getName() + ".THEME_RESOLVER"; public static final String THEME_RESOLVER_ATTRIBUTE = DispatcherServlet.class.getName() + ".THEME_RESOLVER";
@ -234,6 +238,7 @@ public class DispatcherServlet extends FrameworkServlet {
/** /**
* Request attribute to hold the current ThemeSource, retrievable by views. * Request attribute to hold the current ThemeSource, retrievable by views.
* @see org.springframework.web.servlet.support.RequestContextUtils#getThemeSource * @see org.springframework.web.servlet.support.RequestContextUtils#getThemeSource
* @deprecated as of 6.0, with no direct replacement
*/ */
@Deprecated @Deprecated
public static final String THEME_SOURCE_ATTRIBUTE = DispatcherServlet.class.getName() + ".THEME_SOURCE"; public static final String THEME_SOURCE_ATTRIBUTE = DispatcherServlet.class.getName() + ".THEME_SOURCE";

9
spring-webmvc/src/main/java/org/springframework/web/servlet/support/RequestContext.java

@ -409,6 +409,7 @@ public class RequestContext {
* Determine the fallback theme for this context. * Determine the fallback theme for this context.
* <p>The default implementation returns the default theme (with name "theme"). * <p>The default implementation returns the default theme (with name "theme").
* @return the fallback theme (never {@code null}) * @return the fallback theme (never {@code null})
* @deprecated as of 6.0, with no direct replacement
*/ */
@Deprecated @Deprecated
protected org.springframework.ui.context.Theme getFallbackTheme() { protected org.springframework.ui.context.Theme getFallbackTheme() {
@ -447,6 +448,7 @@ public class RequestContext {
* {@link org.springframework.web.servlet.ThemeResolver ThemeResolver}. * {@link org.springframework.web.servlet.ThemeResolver ThemeResolver}.
* @param themeName the name of the new theme * @param themeName the name of the new theme
* @see org.springframework.web.servlet.ThemeResolver#setThemeName * @see org.springframework.web.servlet.ThemeResolver#setThemeName
* @deprecated as of 6.0, with no direct replacement
*/ */
@Deprecated @Deprecated
public void changeTheme(String themeName) { public void changeTheme(String themeName) {
@ -740,6 +742,7 @@ public class RequestContext {
* @param code the code of the message * @param code the code of the message
* @param defaultMessage the String to return if the lookup fails * @param defaultMessage the String to return if the lookup fails
* @return the message * @return the message
* @deprecated as of 6.0, with no direct replacement
*/ */
@Deprecated @Deprecated
public String getThemeMessage(String code, String defaultMessage) { public String getThemeMessage(String code, String defaultMessage) {
@ -755,6 +758,7 @@ public class RequestContext {
* @param args arguments for the message, or {@code null} if none * @param args arguments for the message, or {@code null} if none
* @param defaultMessage the String to return if the lookup fails * @param defaultMessage the String to return if the lookup fails
* @return the message * @return the message
* @deprecated as of 6.0, with no direct replacement
*/ */
@Deprecated @Deprecated
public String getThemeMessage(String code, @Nullable Object[] args, String defaultMessage) { public String getThemeMessage(String code, @Nullable Object[] args, String defaultMessage) {
@ -770,6 +774,7 @@ public class RequestContext {
* @param args arguments for the message as a List, or {@code null} if none * @param args arguments for the message as a List, or {@code null} if none
* @param defaultMessage the String to return if the lookup fails * @param defaultMessage the String to return if the lookup fails
* @return the message * @return the message
* @deprecated as of 6.0, with no direct replacement
*/ */
@Deprecated @Deprecated
public String getThemeMessage(String code, @Nullable List<?> args, String defaultMessage) { public String getThemeMessage(String code, @Nullable List<?> args, String defaultMessage) {
@ -785,6 +790,7 @@ public class RequestContext {
* @param code the code of the message * @param code the code of the message
* @return the message * @return the message
* @throws org.springframework.context.NoSuchMessageException if not found * @throws org.springframework.context.NoSuchMessageException if not found
* @deprecated as of 6.0, with no direct replacement
*/ */
@Deprecated @Deprecated
public String getThemeMessage(String code) throws NoSuchMessageException { public String getThemeMessage(String code) throws NoSuchMessageException {
@ -799,6 +805,7 @@ public class RequestContext {
* @param args arguments for the message, or {@code null} if none * @param args arguments for the message, or {@code null} if none
* @return the message * @return the message
* @throws org.springframework.context.NoSuchMessageException if not found * @throws org.springframework.context.NoSuchMessageException if not found
* @deprecated as of 6.0, with no direct replacement
*/ */
@Deprecated @Deprecated
public String getThemeMessage(String code, @Nullable Object[] args) throws NoSuchMessageException { public String getThemeMessage(String code, @Nullable Object[] args) throws NoSuchMessageException {
@ -813,6 +820,7 @@ public class RequestContext {
* @param args arguments for the message as a List, or {@code null} if none * @param args arguments for the message as a List, or {@code null} if none
* @return the message * @return the message
* @throws org.springframework.context.NoSuchMessageException if not found * @throws org.springframework.context.NoSuchMessageException if not found
* @deprecated as of 6.0, with no direct replacement
*/ */
@Deprecated @Deprecated
public String getThemeMessage(String code, @Nullable List<?> args) throws NoSuchMessageException { public String getThemeMessage(String code, @Nullable List<?> args) throws NoSuchMessageException {
@ -826,6 +834,7 @@ public class RequestContext {
* @param resolvable the MessageSourceResolvable * @param resolvable the MessageSourceResolvable
* @return the message * @return the message
* @throws org.springframework.context.NoSuchMessageException if not found * @throws org.springframework.context.NoSuchMessageException if not found
* @deprecated as of 6.0, with no direct replacement
*/ */
@Deprecated @Deprecated
public String getThemeMessage(MessageSourceResolvable resolvable) throws NoSuchMessageException { public String getThemeMessage(MessageSourceResolvable resolvable) throws NoSuchMessageException {

1
spring-webmvc/src/test/java/org/springframework/web/servlet/config/annotation/InterceptorRegistryTests.java

@ -57,7 +57,6 @@ public class InterceptorRegistryTests {
private final HandlerInterceptor interceptor1 = new LocaleChangeInterceptor(); private final HandlerInterceptor interceptor1 = new LocaleChangeInterceptor();
@Deprecated
private final HandlerInterceptor interceptor2 = new ThemeChangeInterceptor(); private final HandlerInterceptor interceptor2 = new ThemeChangeInterceptor();
private TestWebRequestInterceptor webInterceptor1; private TestWebRequestInterceptor webInterceptor1;

Loading…
Cancel
Save