Browse Source

Actually log the cause of canRead/canWrite failures

Issue: SPR-11403
pull/458/head
Juergen Hoeller 11 years ago
parent
commit
919d6ccb3b
  1. 18
      spring-messaging/src/main/java/org/springframework/messaging/converter/MappingJackson2MessageConverter.java
  2. 18
      spring-web/src/main/java/org/springframework/http/converter/json/MappingJackson2HttpMessageConverter.java

18
spring-messaging/src/main/java/org/springframework/messaging/converter/MappingJackson2MessageConverter.java

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/*
* Copyright 2002-2013 the original author or authors.
* Copyright 2002-2014 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -121,7 +121,13 @@ public class MappingJackson2MessageConverter extends AbstractMessageConverter { @@ -121,7 +121,13 @@ public class MappingJackson2MessageConverter extends AbstractMessageConverter {
}
Throwable cause = causeRef.get();
if (cause != null) {
logger.warn("Failed to evaluate deserialization for type: " + javaType);
String msg = "Failed to evaluate deserialization for type " + javaType;
if (logger.isDebugEnabled()) {
logger.warn(msg, cause);
}
else {
logger.warn(msg + ": " + cause);
}
}
return false;
}
@ -137,7 +143,13 @@ public class MappingJackson2MessageConverter extends AbstractMessageConverter { @@ -137,7 +143,13 @@ public class MappingJackson2MessageConverter extends AbstractMessageConverter {
}
Throwable cause = causeRef.get();
if (cause != null) {
logger.warn("Failed to evaluate serialization for type: " + payload.getClass());
String msg = "Failed to evaluate serialization for type [" + payload.getClass() + "]";
if (logger.isDebugEnabled()) {
logger.warn(msg, cause);
}
else {
logger.warn(msg + ": " + cause);
}
}
return false;
}

18
spring-web/src/main/java/org/springframework/http/converter/json/MappingJackson2HttpMessageConverter.java

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/*
* Copyright 2002-2013 the original author or authors.
* Copyright 2002-2014 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -165,7 +165,13 @@ public class MappingJackson2HttpMessageConverter extends AbstractHttpMessageConv @@ -165,7 +165,13 @@ public class MappingJackson2HttpMessageConverter extends AbstractHttpMessageConv
}
Throwable cause = causeRef.get();
if (cause != null) {
logger.warn("Failed to evaluate deserialization for type: " + javaType);
String msg = "Failed to evaluate deserialization for type " + javaType;
if (logger.isDebugEnabled()) {
logger.warn(msg, cause);
}
else {
logger.warn(msg + ": " + cause);
}
}
return false;
}
@ -181,7 +187,13 @@ public class MappingJackson2HttpMessageConverter extends AbstractHttpMessageConv @@ -181,7 +187,13 @@ public class MappingJackson2HttpMessageConverter extends AbstractHttpMessageConv
}
Throwable cause = causeRef.get();
if (cause != null) {
logger.warn("Failed to evaluate serialization for type: " + clazz);
String msg = "Failed to evaluate serialization for type [" + clazz + "]";
if (logger.isDebugEnabled()) {
logger.warn(msg, cause);
}
else {
logger.warn(msg + ": " + cause);
}
}
return false;
}

Loading…
Cancel
Save