Browse Source

Polishing

pull/22521/head
Juergen Hoeller 6 years ago
parent
commit
e768bba4b5
  1. 4
      spring-context/src/test/java/org/springframework/context/event/EventPublicationInterceptorTests.java
  2. 17
      spring-context/src/test/java/org/springframework/context/event/PayloadApplicationEventTests.java
  3. 2
      spring-jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java

4
spring-context/src/test/java/org/springframework/context/event/EventPublicationInterceptorTests.java

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/*
* Copyright 2002-2016 the original author or authors.
* Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -129,7 +129,7 @@ public class EventPublicationInterceptorTests { @@ -129,7 +129,7 @@ public class EventPublicationInterceptorTests {
public static class FactoryBeanTestListener extends TestListener implements FactoryBean<Object> {
@Override
public Object getObject() throws Exception {
public Object getObject() {
return "test";
}

17
spring-context/src/test/java/org/springframework/context/event/PayloadApplicationEventTests.java

@ -35,10 +35,10 @@ public class PayloadApplicationEventTests { @@ -35,10 +35,10 @@ public class PayloadApplicationEventTests {
@Test
public void testEventClassWithInterface() {
ApplicationContext ac = new AnnotationConfigApplicationContext(Listener.class);
MyEventClass event = new MyEventClass<>(this, "xyz");
ApplicationContext ac = new AnnotationConfigApplicationContext(AuditableListener.class);
AuditablePayloadEvent event = new AuditablePayloadEvent<>(this, "xyz");
ac.publishEvent(event);
assertTrue(ac.getBean(Listener.class).events.contains(event));
assertTrue(ac.getBean(AuditableListener.class).events.contains(event));
}
@ -46,20 +46,17 @@ public class PayloadApplicationEventTests { @@ -46,20 +46,17 @@ public class PayloadApplicationEventTests {
}
public static class MyEventClass<GT> extends PayloadApplicationEvent<GT> implements Auditable {
@SuppressWarnings("serial")
public static class AuditablePayloadEvent<T> extends PayloadApplicationEvent<T> implements Auditable {
public MyEventClass(Object source, GT payload) {
public AuditablePayloadEvent(Object source, T payload) {
super(source, payload);
}
public String toString() {
return "Payload: " + getPayload();
}
}
@Component
public static class Listener {
public static class AuditableListener {
public final List<Auditable> events = new ArrayList<>();

2
spring-jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java

@ -612,6 +612,7 @@ public class JdbcTemplate extends JdbcAccessor implements JdbcOperations { @@ -612,6 +612,7 @@ public class JdbcTemplate extends JdbcAccessor implements JdbcOperations {
((ParameterDisposer) psc).cleanupParameters();
}
String sql = getSql(psc);
psc = null;
JdbcUtils.closeStatement(ps);
ps = null;
DataSourceUtils.releaseConnection(con, getDataSource());
@ -1053,6 +1054,7 @@ public class JdbcTemplate extends JdbcAccessor implements JdbcOperations { @@ -1053,6 +1054,7 @@ public class JdbcTemplate extends JdbcAccessor implements JdbcOperations {
((ParameterDisposer) csc).cleanupParameters();
}
String sql = getSql(csc);
csc = null;
JdbcUtils.closeStatement(cs);
cs = null;
DataSourceUtils.releaseConnection(con, getDataSource());

Loading…
Cancel
Save