Browse Source

Update HttpHeaders.getAccept method

Some servlet containers (iPlanet) parse the Accept header and return
multiple values from request.getHeader("Accept"). The HttpHeaders
getAccept method has been updated to accommodate that hopefully
without causing any other issues.

The extra functionality is in effect only if we find only one
MediaType and there is more than one value for the 'Accept' header.

Issue: SPR-9655
pull/1536/head
Rossen Stoyanchev 12 years ago
parent
commit
f2d7d663b4
  1. 12
      org.springframework.web/src/main/java/org/springframework/http/HttpHeaders.java
  2. 12
      org.springframework.web/src/test/java/org/springframework/http/HttpHeadersTests.java

12
org.springframework.web/src/main/java/org/springframework/http/HttpHeaders.java

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2011 the original author or authors. * Copyright 2002-2012 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -146,7 +146,15 @@ public class HttpHeaders implements MultiValueMap<String, String> {
*/ */
public List<MediaType> getAccept() { public List<MediaType> getAccept() {
String value = getFirst(ACCEPT); String value = getFirst(ACCEPT);
return (value != null ? MediaType.parseMediaTypes(value) : Collections.<MediaType>emptyList()); List<MediaType> result = (value != null) ? MediaType.parseMediaTypes(value) : Collections.<MediaType>emptyList();
// Some containers parse 'Accept' into multiple values
if ((result.size() == 1) && (headers.get(ACCEPT).size() > 1)) {
value = StringUtils.collectionToCommaDelimitedString(headers.get(ACCEPT));
result = MediaType.parseMediaTypes(value);
}
return result;
} }
/** /**

12
org.springframework.web/src/test/java/org/springframework/http/HttpHeadersTests.java

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2011 the original author or authors. * Copyright 2002-2012 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -55,6 +55,16 @@ public class HttpHeadersTests {
assertEquals("Invalid Accept header", "text/html, text/plain", headers.getFirst("Accept")); assertEquals("Invalid Accept header", "text/html, text/plain", headers.getFirst("Accept"));
} }
// SPR-9655
@Test
public void acceptiPlanet() {
headers.add("Accept", "text/html");
headers.add("Accept", "text/plain");
List<MediaType> expected = Arrays.asList(new MediaType("text", "html"), new MediaType("text", "plain"));
assertEquals("Invalid Accept header", expected, headers.getAccept());
}
@Test @Test
public void acceptCharsets() { public void acceptCharsets() {
Charset charset1 = Charset.forName("UTF-8"); Charset charset1 = Charset.forName("UTF-8");

Loading…
Cancel
Save