Juergen Hoeller
63d6215247
Polishing
6 years ago
Juergen Hoeller
5dc8b5de6d
Polishing
6 years ago
Juergen Hoeller
4ff1e3e74b
Consistent abstract declaration for utility classes (plus polishing)
...
Issue: SPR-16968
6 years ago
Phillip Webb
a89e716cc7
Use tabs rather than spaces in tests
...
Update tests to ensure that tabs are used instead of spaces. Also
consistently apply a new line at the end of each file.
Issue: SPR-16968
6 years ago
Phillip Webb
1c25cec44f
Polish test code
...
Polish a few issue identified when adding checkstyle to the
build. Although checkstyle is not enforcing rules on tests,
these are a few minor changes that are still worth making.
Issue: SPR-16968
6 years ago
Phillip Webb
81451aa800
Organize imports
...
Reorganize imports to ensure consistent ordering. This commit also
expands any `.*` static imports in favor of using fully-qualified
method references.
Issue: SPR-16968
6 years ago
Phillip Webb
5cedd0d5d4
Consistently use tabs rather than spaces
...
Update code that has accidentally used spaces instead of tabs.
Also remove all trailing whitespace.
Issue: SPR-16968
6 years ago
Phillip Webb
0b53c1096a
Always use 'this.' when accessing fields
...
Ensure that `this.` is used consistently when accessing class
fields.
Issue: SPR-16968
6 years ago
Phillip Webb
eeebd51f57
Use consistent class design
...
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968
6 years ago
Phillip Webb
866e9d702e
Use consistent block style
...
Update all code to use a consistent block style.
Issue: SPR-16968
6 years ago
Phillip Webb
e0480f75ac
Fix javadoc checkstyle issues
...
Fix checkstyle violations for javadoc.
Issue: SPR-16968
6 years ago
Juergen Hoeller
7bce7504c7
JdbcTemplate consistently exposes first value of equally named columns
...
Issue: SPR-16578
7 years ago
Juergen Hoeller
25559b9e44
Polishing
7 years ago
Juergen Hoeller
0941081b0a
Upgrade to HSQLDB 2.4.1, Derby 10.14.2.0, HtmlUnit 2.31, Selenium 3.12
7 years ago
Juergen Hoeller
d9c63182d9
MapSqlParameterSource.addValue declares nullable value parameter
...
Issue: SPR-16843
7 years ago
nkjackzhang
a1fa0daad5
Fix a typo in javadoc
...
Closes gh-1824
7 years ago
Johnny Lim
fb898e1727
Remove inconsistent spaces
7 years ago
Johnny Lim
8f21cb1a7c
Polish DatabaseStartupValidator
7 years ago
Juergen Hoeller
e170cb0f79
Upgrade framework build to JPA 2.2 and JTA 1.3
...
Issue: SPR-16685
7 years ago
Juergen Hoeller
ff53d78e96
Remove bogus DataSource test from JpaTransactionManagerTests
7 years ago
Juergen Hoeller
475c4d4425
Polishing
7 years ago
Juergen Hoeller
0bc01fcd55
Polishing
7 years ago
Johnny Lim
8dd0974e2f
Rename SingleColumnRowMapperTest to align with the other tests
7 years ago
Juergen Hoeller
9a722b4558
Pass type name into PreparedStatement.setNull in case of Types.OTHER
...
Issue: SPR-16669
7 years ago
nkjackzhang
82cb5dbf2b
NamedParameterUtils.parseSqlStatement should parse :{x} style parameter correctly
...
In my opinion, we should parse ":{x}" style parameter as "x" is parameter using "NamedParameterUtils.parseSqlStatement",
so the condition "j - i > 2" is the correct condition, not "j - i > 3", because if "i" is the index of
":" in ":{x}", and "j" is the index of "}" in ":{x}", "j - i == 3" is true.
Also add a test case for SPR-16663.
7 years ago
Juergen Hoeller
b2d87abcbb
Polishing
7 years ago
Juergen Hoeller
e3d0ef6015
Use Map.forEach instead of manual Map.Entry iteration wherever possible
...
Issue: SPR-16646
7 years ago
Juergen Hoeller
c441d60d1d
Upgrade to Kotlin 1.2.31 and RxJava 2.1.12
...
Includes H2 1.4.197 and Selenium HtmlUnit Driver 2.29.3 as well.
7 years ago
Juergen Hoeller
702b27e1e4
Polishing
7 years ago
Juergen Hoeller
2c7efbb9d0
Deprecate TableMetaDataContext.getSimulationQueryForGetGeneratedKey
7 years ago
Juergen Hoeller
b7c423813d
CallMetaDataContext handles 'procedureColumnResult' as return parameter
...
Issue: SPR-16611
7 years ago
Juergen Hoeller
4fef1fe820
Polishing
7 years ago
igor-suhorukov
2f9d0a7de8
simplify boolean NOT operation
7 years ago
igor-suhorukov
32b689a994
use StringBuilder for complex string concatenation
7 years ago
igor-suhorukov
407ecf7334
to get rid of "magic" time constants
7 years ago
Juergen Hoeller
50253f670e
Quick access to volatile field (full synchronization only for lazy init)
...
Issue: SPR-16570
7 years ago
Juergen Hoeller
139dc1d373
Polishing (collapsed if checks, consistent downcasts, refined javadoc)
7 years ago
igor-suhorukov
0f7485b01d
Polish: reorder the modifiers to comply with the Java Language Specification.
7 years ago
Juergen Hoeller
20287e0cb0
Polishing
7 years ago
Juergen Hoeller
82515a3f01
Consistent incrementer arrangement for PostgreSQL, DB2 and SAP HANA
...
Includes related polishing in core.metadata and datasource.embedded and a revision of the corresponding database definitions in sql-error-codes.
Issue: SPR-16558
7 years ago
Juergen Hoeller
4a4f2c2f08
Drop version check in isGetGeneratedKeysSimulated (for PostgreSQL 10)
...
Issue: SPR-16556
7 years ago
igor-suhorukov
49fd724d8f
Polish: String function use should be optimized for single characters
7 years ago
Juergen Hoeller
3732032ee4
Customizable PreparedStatementCreator in NamedParameterJdbcTemplate
...
Issue: SPR-16050
7 years ago
igor-suhorukov
c782075a13
Polish: Array designators "[]" should be on the type, not the variable
7 years ago
Juergen Hoeller
a5cbf5fe24
Consistent use of Collection.toArray with zero-sized array argument
...
Includes consistent use of ClassUtils.toClassArray (as non-null variant)
Issue: SPR-16523
7 years ago
Juergen Hoeller
d7cab23e6d
Consistent use of StringUtils.toStringArray
...
(cherry picked from commit 6d11b40
)
7 years ago
Juergen Hoeller
8d3264f680
Prefer List.sort(Comparator) over Collections.sort(List, Comparator)
7 years ago
Juergen Hoeller
3b810f3544
Consistent Class array vs vararg declarations (and related polishing)
7 years ago
Juergen Hoeller
766e6028d7
Defensively handle DatabaseMetaData.getConnection() returning null
...
Issue: SPR-16495
7 years ago
Kazuki Shimizu
8c623c8a42
Supports ConversionService on SingleColumnRowMapper
...
Issue: SPR-16483
7 years ago