Juergen Hoeller
40efcc933c
Polishing
6 years ago
Phillip Webb
634f5c2792
Ensure when equals() is implemented so is hashCode()
...
Update classes that override `equals()` to ensure that they also
implement `hashCode()`.
Issue: SPR-16968
6 years ago
Phillip Webb
0b53c1096a
Always use 'this.' when accessing fields
...
Ensure that `this.` is used consistently when accessing class
fields.
Issue: SPR-16968
6 years ago
Phillip Webb
eeebd51f57
Use consistent class design
...
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968
6 years ago
Phillip Webb
04a8c285df
Fix annotation styling issues
...
Update all annotations so that each is on its own line and
consistently use the short form (i.e. don't use `value=`) when
possible.
Issue: SPR-16968
6 years ago
Phillip Webb
e0480f75ac
Fix javadoc checkstyle issues
...
Fix checkstyle violations for javadoc.
Issue: SPR-16968
6 years ago
Juergen Hoeller
8e1ececd97
Fine-tuned JCA MessageEndpoint exception logging and propagation
...
Issue: SPR-16717
7 years ago
Juergen Hoeller
e170cb0f79
Upgrade framework build to JPA 2.2 and JTA 1.3
...
Issue: SPR-16685
7 years ago
Juergen Hoeller
ff53d78e96
Remove bogus DataSource test from JpaTransactionManagerTests
7 years ago
Juergen Hoeller
d553ddc5b3
Nullability refinements (based on IntelliJ IDEA 2018.1 introspection)
...
Issue: SPR-15756
7 years ago
Juergen Hoeller
e3d0ef6015
Use Map.forEach instead of manual Map.Entry iteration wherever possible
...
Issue: SPR-16646
7 years ago
Juergen Hoeller
f00afe3247
Use (Concurrent)Map.computeIfAbsent for lazy nested collection creation
7 years ago
Juergen Hoeller
d4a8f76bf9
Consistent volatile access to running flag in Lifecycle implementations
...
Issue: SPR-16488
7 years ago
Juergen Hoeller
f57fcdee3c
Polishing
7 years ago
Juergen Hoeller
6f7ad0304c
Polishing
7 years ago
igor-suhorukov
8080f56db8
Polish: "@Override" should be used on overriding and implementing methods
7 years ago
Juergen Hoeller
a19d4deb24
Polishing
7 years ago
Juergen Hoeller
9962df6527
Polishing
7 years ago
Juergen Hoeller
95aad9cdc2
Interrupt listener invoker threads on shutdown (after initial wait step)
...
Issue: SPR-16536
7 years ago
igor-suhorukov
d1ccecd021
Polish: to get rid unnecessary array creation
7 years ago
igor-suhorukov
7bce04c06c
Polish: combine catches block with same body
7 years ago
Juergen Hoeller
a5cbf5fe24
Consistent use of Collection.toArray with zero-sized array argument
...
Includes consistent use of ClassUtils.toClassArray (as non-null variant)
Issue: SPR-16523
7 years ago
Juergen Hoeller
95f7180298
Explicit documentation notes on transacted sessions vs AUTO_ACKNOWLEDGE
...
Issue: SPR-16487
7 years ago
igor-suhorukov
7826567df6
Polish: lamdbas containing only one statement should not nest this statement in a block
7 years ago
igor-suhorukov
0ee505b73e
Polish: assertion arguments should be passed in the correct order,
...
use assertNull instead of assertEquals(null, value),
declare delta as double value in assertEquals
7 years ago
igor-suhorukov
9a6fbf59c5
Polish: follow name convention - make immutable fields final
7 years ago
Juergen Hoeller
b6ecfcf9ec
CachingConnectionFactory makes its Session caching inactive during reset
...
Issue: SPR-16450
7 years ago
Juergen Hoeller
572c668726
Polishing
7 years ago
Juergen Hoeller
65a167f7fd
JmsListenerAnnotationBeanPostProcessor properly deals with nested proxies
...
Issue: SPR-16196
7 years ago
Stephane Nicoll
42dfa40151
Make sure endpoint settings override default factory settings
...
Issue: SPR-16338
7 years ago
Juergen Hoeller
4c9ed0d87e
Polishing
7 years ago
Juergen Hoeller
4adc820714
Warning instead of error for non-present type filter class
...
Issue: SPR-16356
7 years ago
Juergen Hoeller
72590dbb21
CachingConnectionFactory does not cache producer for temporary queue/topic
...
Issue: SPR-16353
7 years ago
Juergen Hoeller
4a57e26d76
Polishing
7 years ago
Juergen Hoeller
d1fac36e3e
SchedulingConfigurer and JmsListenerConfigurer respect @Order
...
Issue: SPR-16090
7 years ago
Juergen Hoeller
75bd516251
Refined TemporaryLobCreator null handling (from 4.3.x)
...
Issue: SPR-15656
7 years ago
Juergen Hoeller
efce7902c4
Polishing
7 years ago
Juergen Hoeller
9190b76ab9
Latest dependency updates (POI 3.17, Rome 1.8, EhCache 3.4, Caffeine 2.5.6, RxJava 2.1.4, Tomcat 8.5.21, JRuby 9.1.13, Rhino 1.7.7.2)
7 years ago
Juergen Hoeller
7ae59d0c2a
Nullability refinements on private and static methods
...
Based on IntelliJ IDEA 2017.3 introspection results.
Issue: SPR-15756
7 years ago
Stephane Nicoll
b275a06d16
Reuse JmsTemplate's MessageConverter in JmsMessagingTemplate
...
This commit makes sure that any custom MessageConverter set in a
JmsTemplate used by a JmsMessagingTemplate is reused as the payload
converter of the message.
Issue: SPR-15965
7 years ago
Stephane Nicoll
7aa956a920
Polish
7 years ago
Sebastien Deleuze
1bc93e3d0f
Revisit nullability annotations
...
This commit introduces the following changes.
1) It adds a new Spring @NonNull annotation which allows to apply
@NonNullApi semantic on a specific element, like @Nullable does.
Combined with @Nullable , it allows partial null-safety support when
package granularity is too broad.
2) @Nullable and @NonNull can apply to ElementType.TYPE_USE in order
to be used on generic type arguments (SPR-15942).
3) Annotations does not apply to ElementType.TYPE_PARAMETER anymore
since it is not supported yet (applicability for such use case is
controversial and need to be discussed).
4) @NonNullApi does not apply to ElementType.FIELD anymore since in a
lot of use cases (private, protected) it is not part for the public API
+ its usage should remain opt-in. A dedicated @NonNullFields annotation
has been added in order to set fields default to non-nullable.
5) Updated Javadoc and reference documentation.
Issue: SPR-15756
7 years ago
Brian Clozel
2eeb428e95
Move modules to independent build files
...
The main `build.gradle` file contains now only the common build
infrastructure; all module-specific build configurations have
been moved to their own build file.
Issue: SPR-15885
7 years ago
Juergen Hoeller
47a7475898
Resolve remaining nullability warnings
...
Issue: SPR-15869
7 years ago
Sebastien Deleuze
73cf07e9a4
Fix overridden methods nullability
...
Issue: SPR-15869
7 years ago
Juergen Hoeller
46eba3dbfa
Nullability fine-tuning around declaration inconsistencies
...
Issue: SPR-15720
Issue: SPR-15792
7 years ago
Juergen Hoeller
9fc4fb10b0
Nullability fine-tuning around bean properties
...
Issue: SPR-15720
Issue: SPR-15792
7 years ago
Sebastien Deleuze
fb4ddb0746
Make getters and setters null-safety consistent
...
This commit ensure that null-safety is consistent between
getters and setters in order to be able to provide beans
with properties with a common type when type safety is
taken in account like with Kotlin.
It also add a few missing property level @Nullable
annotations.
Issue: SPR-15792
7 years ago
Juergen Hoeller
c292a89b24
Http(Async)Client not actually nullable, plus MethodInterceptor nullability
...
Issue: SPR-15720
7 years ago
Juergen Hoeller
6d55b3a592
Perform onException delegation outside of connection monitor
...
Issue: SPR-15738
7 years ago