Juergen Hoeller
22aba8bf60
Upgrade to Apache HttpClient 4.5.9
6 years ago
Juergen Hoeller
7dc92aa05d
Polishing
6 years ago
Rossen Stoyanchev
0757eaee9d
Clear ProducesRequestCondition attribute
...
Closes gh-23091
6 years ago
Sam Brannen
2f640fe205
Polish FreeMarker macro support in spring-webflux
...
See gh-23002
6 years ago
Sam Brannen
ac28de0dc1
Polish Javadoc for FreeMarker support
6 years ago
Sam Brannen
9b084bb3ea
Polish contribution
...
See gh-23073
6 years ago
Issam El-atif
ab36a0a82f
Improve FreeMarker tests in spring-webmvc and spring-context-support
...
This commit improves FreeMarkerConfigurerTests in spring-webmvc by
testing against FreeMarkerConfigurer instead of
FreeMarkerConfigurationFactoryBean and moves the original
FreeMarkerConfigurationFactoryBeanTests to spring-context-support in
the org.springframework.ui.freemarker package.
Closes gh-23073
6 years ago
Sebastien Deleuze
098ac0bbb8
Annotate Object#equals parameter with @Nullable
...
Closes gh-23093
6 years ago
Sam Brannen
2074afc87f
Polish Javadoc
...
See gh-23075
6 years ago
Arjen Poutsma
145610129b
Javadoc
...
Closes gh-23075
6 years ago
Brian Clozel
4b8ce04bdc
Mark Spring web config classes as proxyBeanMethods=false
...
Closes gh-23004
6 years ago
Johnny Lim
83078eb6fd
Add constants for application/cbor to MediaType
...
Closes gh-23042
6 years ago
Sam Brannen
141ef9082f
Clean up Mockito usage
...
This commit migrates to the MockitoJUnitRunner where sensible, which
will later allow for an easier migration to Mockito's extension for
JUnit Jupiter.
In addition, this commit deletes unnecessary stubbing for various mocks
and polishes test fixture setup in various test classes.
6 years ago
Sebastien Deleuze
bc205e0dbf
Remove charset parameter from Spring MVC JSON content type
...
This change is a follow-up to the ones done as part of gh-22788.
Closes gh-22954
6 years ago
Sam Brannen
09db8881bb
Fix Checkstyle violation
6 years ago
stsypanov
4cc7b9b9fc
tiny simplifications regarding usage of Iterator
6 years ago
Phillip Webb
9d74da006c
Migrate JUnit 4 assertions to AssertJ
...
Migrate all existing JUnit 4 `assert...` based assertions to AssertJ
and add a checkstyle rule to ensure they don't return.
See gh-23022
6 years ago
Phillip Webb
95a9d46a87
Migrate Hamcrest assertions to AssertJ
...
Migrate all existing `assertThat(..., Matcher)` assertions to AssertJ
and add checkstyle rules to ensure they don't return.
See gh-23022
6 years ago
Juergen Hoeller
5aa0de7ac8
Upgrade to OkHttp 3.14.2, Joda-Time 2.10.2, OpenPDF 1.2.17, JRuby 9.2.7
6 years ago
Arjen Poutsma
9b3c92e8d2
Add leading slash for path predicate if not present
...
This commit adds a leading slash for path predicates in both
WebFlux.fn and WebMvc.fn.
Closes gh-22795
6 years ago
Phillip Webb
02850f357f
Migrate exception checking tests to use AssertJ
...
Migrate tests that use `@Test(expectedException=...)` or
`try...fail...catch` to use AssertJ's `assertThatException`
instead.
6 years ago
Juergen Hoeller
c5d6b74321
Fix stale-if-error xsd documentation
...
Closes gh-22983
6 years ago
stsypanov
9ca8681f79
Iteration over a map using EntrySet
6 years ago
Juergen Hoeller
daee6f5bd9
Avoid expensive assertions in web resource resolution
...
Closes gh-22955
6 years ago
Johnny Lim
9a6ce66bd9
Add a missing single quote in assertion message
6 years ago
Sam Brannen
73dbd06361
Enforces static imports for JUnit 4 assertions and assumptions
...
This commit configures Checkstyle to enforces static imports for JUnit 4
assertions and assumptions.
See gh-22932
6 years ago
Sam Brannen
deecab6311
Use assertThat from Hamcrest instead of JUnit 4
...
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894
6 years ago
Sam Brannen
724c805211
Discontinue use of JUnit 3 APIs
...
This commit also ensures that the JSR-330 TCK is executed with the
normal build by adhering to naming conventions for test classes.
See gh-22894
6 years ago
Sam Brannen
64819bbc1d
Clean up warnings
6 years ago
Sam Brannen
e465f51d56
Suppress deprecation warnings
6 years ago
Phillip Webb
798b51f4a3
Migrate to BDD Mockito
...
Migrate all tests to consistently use BDD Mockito. Also add
checksyle rule to enforce going forwards.
6 years ago
Phillip Webb
816bbee8de
Remove '.*' imports from tests
...
Organize test imports to expand all '.*' static imports into
fully qualified imports.
This update will allow us to use additional checkstyle rules in
the future, and will also help if we migrate fully to AssertJ.
6 years ago
Sam Brannen
4038d590a1
Suppress deprecation warning in Gradle build
6 years ago
Sam Brannen
4d1637a9b7
Avoid warnings in RequestMappingHandlerMappingTests
6 years ago
Phil Webb
d7320de871
Migrate away from ExpectedException ( #22922 )
...
* Add limited checkstyles to test code
Add a limited set of checkstyle rules to the test codebase to improve
code consistency.
* Fix checksyle violations in test code
* Organize imports to fix checkstyle for test code
* Migrate to assertThatExceptionOfType
Migrate aware from ExpectedException rules to AssertJ exception
assertions. Also include a checkstyle rules to ensure that the
the ExpectedException is not accidentally used in the future.
See gh-22894
6 years ago
Rossen Stoyanchev
7e6e3d7027
Switch writeAcceptCharset to false by default
...
Closes gh-22506
6 years ago
Rossen Stoyanchev
45147c23c1
Empty body checks in ConsumesRequestCondition
...
Normally consumes matches the "Content-Type" header but what should be done if
there is no content? This commit adds checks for method parameters with
@RequestBody(required=false) and if "false" then also match requests with no content.
Closes gh-22010
6 years ago
Arjen Poutsma
00a5106bfa
Add route(RequestPredicate, HandlerFunction) to RouterFunctions builder
...
Closes gh-22701
6 years ago
Arjen Poutsma
55b56b8c5c
Javadoc
...
Closes gh-22893
6 years ago
Sam Brannen
4aaec942c4
Introduce HTTPS mappings in spring.schemas files
...
Closes gh-22903
6 years ago
Rossen Stoyanchev
53cadf15e7
Deferred handling of Flux error in Spring MVC
...
This commit defers flushing of the response until the first item is
emitted that needs to be written (and flushed) to the response.
This makes Spring MVC consistent with WebFlux in this regard.
Closes gh-21972
6 years ago
Sam Brannen
d616e10dca
Use assertThat from Hamcrest instead of JUnit 4
...
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894
6 years ago
Johnny Lim
d489227874
Use HttpHeaders constants where possible
6 years ago
Juergen Hoeller
a7949ac84a
Consistent use of StringUtils.hasLength(String) vs isEmpty(Object)
6 years ago
Juergen Hoeller
31c3b8a291
Avoid unguarded String concatenation for debug/trace logging
...
Closes gh-22874
6 years ago
Juergen Hoeller
8a57997d21
Avoid use of Objects.requireNonNull plus related polishing
6 years ago
Rossen Stoyanchev
b398216191
Fail proactively if lookupPath not in requestUri
...
Closes gh-22851
6 years ago
Rossen Stoyanchev
b5327ef60f
Fix regression in ProducesRequestCondition
...
Closes gh-22853
6 years ago
Juergen Hoeller
e0423fbdc2
Revise inline comment for logException call
...
Closes gh-22794
6 years ago
Juergen Hoeller
359c4f091e
Add rejectInvalidCookies flag to CookieLocaleResolver
...
Closes gh-22861
6 years ago