Juergen Hoeller
58011f71e9
Consistent assertions for template method result vs servlet registration
7 years ago
Brian Clozel
ed7684d2b2
Don't implicitly check preconditions on PUT requests
...
Prior to this commit, the `HttpEntityMethodProcessor` would check HTTP
conditions on non-safe requests (i.e. not GET/HEAD). This would prevent
Controllers from returning `ResponseEntity` containing response headers
with updated values of `"Last-Modified"` or `ETag` once the resource has
been updated.
This commit avoids those checks for non GET/HEAD requests - this code
can still be leveraged from Controllers themselves using
`ServletWebRequest::checkNotModified` methods.
Issue: SPR-15780
7 years ago
Juergen Hoeller
139dc1d373
Polishing (collapsed if checks, consistent downcasts, refined javadoc)
7 years ago
igor-suhorukov
0f7485b01d
Polish: reorder the modifiers to comply with the Java Language Specification.
7 years ago
Rossen Stoyanchev
568c93457a
Improve ResponseBodyEmitter error handling
...
After send error, ignore calls to complete or completeWithError by the
application in the same thread (e.g. try-catch block), to avoid a
competing with an error callback from servlet container during which
the same action is taken.
Issue: SPR-16548
7 years ago
Rossen Stoyanchev
e20652009d
Improve docs on SseEmitter onComplete/onError
...
Issue: SPR-16548
7 years ago
Juergen Hoeller
934a995acb
Strong recommendation for OpenPDF 1.0.5 instead of iText 2.1.7
...
Issue: SPR-16107
(cherry picked from commit b70d400
)
7 years ago
Juergen Hoeller
f57fcdee3c
Polishing
7 years ago
Patrick0308
6f4d25a6e6
Polish "Use Java 8 forEach method on Map"
7 years ago
Brian Clozel
6d26e61ac7
Guard against invalid paths in ResourceUrlProvider
...
This commit makes sure that no `StringIndexOutOfBoundsException` is
thrown when `getForRequestUrl` is called with a URL that's shorter than
the expected context path.
Issue: SPR-16526
7 years ago
Juergen Hoeller
cd4f0935c5
Revised deprecation markers
7 years ago
Rossen Stoyanchev
36cfdf68b1
Correct log level
...
Issue: SPR-16528
7 years ago
Juergen Hoeller
bfddbbe731
Polishing
7 years ago
igor-suhorukov
83300c4b27
Polish: follow naming convention
7 years ago
igor-suhorukov
8080f56db8
Polish: "@Override" should be used on overriding and implementing methods
7 years ago
igor-suhorukov
d1ccecd021
Polish: to get rid unnecessary array creation
7 years ago
igor-suhorukov
7bce04c06c
Polish: combine catches block with same body
7 years ago
igor-suhorukov
49fd724d8f
Polish: String function use should be optimized for single characters
7 years ago
Juergen Hoeller
a5cbf5fe24
Consistent use of Collection.toArray with zero-sized array argument
...
Includes consistent use of ClassUtils.toClassArray (as non-null variant)
Issue: SPR-16523
7 years ago
Juergen Hoeller
0de36d2883
Consistent HttpMethod identity comparisons
7 years ago
Juergen Hoeller
d7cab23e6d
Consistent use of StringUtils.toStringArray
...
(cherry picked from commit 6d11b40
)
7 years ago
Juergen Hoeller
8d3264f680
Prefer List.sort(Comparator) over Collections.sort(List, Comparator)
7 years ago
igor-suhorukov
2be4985b8f
Polish: anonymous inner classes containing only one method should become lambdas,
...
use getOrDefault instead of ternary operator
7 years ago
Rossen Stoyanchev
9801afb85d
Fix compile error
...
Update places that call UriUtils to catch the right exception that is
now raised as a result of using Charet.forName.
7 years ago
Juergen Hoeller
cd8a1bdb8b
AcceptHeaderLocaleContextResolver leniently handles invalid header value
...
Also falls back to language-only match among its supported locales now.
Issue: SPR-16500
Issue: SPR-16457
7 years ago
Juergen Hoeller
6d7573262e
FormTag skips rendering of hidden fields in case of empty Map
...
Issue: SPR-16498
7 years ago
Juergen Hoeller
3b810f3544
Consistent Class array vs vararg declarations (and related polishing)
7 years ago
Juergen Hoeller
46cbdff5c3
Consistent ControllerAdvice applicability against user-declared class
...
Issue: SPR-16496
7 years ago
igor-suhorukov
711b0f50f2
Polish: replace the synchronized class "Stack" by an unsynchronized one such as "Deque".
7 years ago
igor-suhorukov
0ee505b73e
Polish: assertion arguments should be passed in the correct order,
...
use assertNull instead of assertEquals(null, value),
declare delta as double value in assertEquals
7 years ago
Stephane Nicoll
991eb4858e
Update copyright header
7 years ago
igor-suhorukov
e381514b07
Collection.isEmpty() should be used to test for emptiness
...
Closes gh-1670
7 years ago
igor-suhorukov
4c888d0f32
Polish
...
Closes gh-1669
7 years ago
Juergen Hoeller
4dc964544f
AcceptHeaderLocaleResolver falls back to language-only match among its supported locales
...
Issue: SPR-16457
7 years ago
Juergen Hoeller
7f96827ade
Polishing
7 years ago
Juergen Hoeller
4a1cc9ced7
Constructor-provided field values get recorded for failed binding result
...
Also, TypeMismatchExceptions get registered via BindingErrorProcessor.
Issue: SPR-16449
7 years ago
Rossen Stoyanchev
0ded239453
[doc] Update Spring MVC exception handling content
...
Issue: SPR-16394
7 years ago
sdeleuze
b6c78452b2
Update and improve script templating documentation
...
Issue: SPR-16447
7 years ago
Juergen Hoeller
61579ffe7b
Polishing
7 years ago
Juergen Hoeller
9d0e62ef68
Javadoc format and related polishing
7 years ago
Johnny Lim
36d42bcda4
Polish InterceptorRegistration
...
Closes gh-1647
7 years ago
Juergen Hoeller
ea5f8f5a7c
Consistently handle NoClassDefFoundError in BeanUtils and related places
...
Issue: SPR-16369
7 years ago
Juergen Hoeller
121f9e3734
BridgeMethodResolver properly resolves all declared interfaces
...
Issue: SPR-16288
7 years ago
Rossen Stoyanchev
ea73ec5c41
ResourceUrlProvider handles sanitizes double slashes
...
Issue: SPR-16296
7 years ago
Rossen Stoyanchev
846636f2b9
Polish
7 years ago
Aleksey Voronenkov
cb8ad46564
Overloaded methods in InterceptorRegistration
...
Issue: SPR-16324
7 years ago
Rossen Stoyanchev
446e7ed25c
Links from @RequestMapping to reference docs
...
Issue: SPR-16266
7 years ago
Rossen Stoyanchev
fda08852ba
Take content-type from ResponseEntity unconditionally
...
From #9a894a we began using the content-type from the ResponseEntity
but cross-checking it still against the requested content type.
Arguably there isn't any purpose in cross-checking. The only possible
outcomes are: a) it's compatible or b) it's not, which would result in
406 (NOT_ACCEPTABLE). As we've been given explicitly the media type to
use, it makes little sense to send 406, ignoring the wish to use that
content type.
Issue: SPR-16251
7 years ago
Rossen Stoyanchev
3650ecc3bb
Polish
7 years ago
sdeleuze
652e5c5584
Disable CORS credentials by default
...
Access-Control-Allow-Credentials CORS header, used to
allow cookies with CORS requests, is not set to true
anymore by default when enabling CORS with
@CrossOrigin or global CORS configuration in order to
provide a more secured default CORS configuration.
The related allowCredentials property now requires to
be set to true explicitly in order to support cookies
with CORS requests.
Issue: SPR-16130
7 years ago