Spring Framework

spring framework spring-framework

Sam Brannen 0998bd49ef Implement reliable advice invocation order within an @Aspect The AspectJPrecedenceComparator was designed to mimic the precedence order enforced by the AspectJ compiler with regard to multiple 'after' methods defined within the same aspect whose pointcuts match the same joinpoint. Specifically, if an aspect declares multiple @After, @AfterReturning, or @AfterThrowing advice methods whose pointcuts match the same joinpoint, such 'after' advice methods should be invoked in the reverse order in which they are declared in the source code. When the AspectJPrecedenceComparator was introduced in Spring Framework 2.0, it achieved its goal of mimicking the AspectJ compiler since the JDK at that time (i.e., Java 5) ensured that an invocation of Class#geDeclaredMethods() returned an array of methods that matched the order of declaration in the source code. However, Java 7 removed this guarantee. Consequently, in Java 7 or higher, AspectJPrecedenceComparator no longer works as it is documented or as it was designed when sorting advice methods in a single @Aspect class. Note, however, that AspectJPrecedenceComparator continues to work as documented and designed when sorting advice configured via the <aop:aspect> XML namespace element. PR gh-24673 highlights a use case where AspectJPrecedenceComparator fails to assign the highest precedence to an @After advice method declared last in the source code. Note that an @After advice method with a precedence higher than @AfterReturning and @AfterThrowing advice methods in the same aspect will effectively be invoked last due to the try-finally implementation in AspectJAfterAdvice.invoke() which invokes proceed() in the try-block and invokeAdviceMethod() in the finally-block. Since Spring cannot reliably determine the source code declaration order of annotated advice methods without using ASM to analyze the byte code, this commit introduces reliable invocation order for advice methods declared within a single @Aspect. Specifically, the getAdvisors(...) method in ReflectiveAspectJAdvisorFactory now hard codes the declarationOrderInAspect to `0` instead of using the index of the current advice method. This is necessary since the index no longer has any correlation to the method declaration order in the source code. The result is that all advice methods discovered via reflection will now be sorted only according to the precedence rules defined in the ReflectiveAspectJAdvisorFactory.METHOD_COMPARATOR. Specifically, advice methods within a single @Aspect will be sorted in the following order (with @After advice methods effectively invoked after @AfterReturning and @AfterThrowing advice methods): @Around, @Before, @After, @AfterReturning, @AfterThrowing. The modified assertions in AspectJAutoProxyAdviceOrderIntegrationTests demonstrate the concrete effects of this change. Closes gh-25186		4 years ago
.github	Configure Gradle wrapper validation action	5 years ago
buildSrc	Fix typo in buildSrc/README.md	5 years ago
framework-bom	Remove scope information from published BOM	5 years ago
gradle	Upgrade to spring-doc-resources 0.2.1	5 years ago
integration-tests	Implement reliable advice invocation order within an @Aspect	4 years ago
spring-aop	Implement reliable advice invocation order within an @Aspect	4 years ago
spring-aspects	Remove unnecessary dependency on spring-orm	5 years ago
spring-beans	Polishing	5 years ago
spring-context	Support for shared GroovyClassLoader in GroovyScriptFactory	5 years ago
spring-context-indexer	Polish contribution	5 years ago
spring-context-support	Polishing	5 years ago
spring-core	Polishing	5 years ago
spring-expression	Use autoboxing instead of explicit wrapping in tests	5 years ago
spring-instrument	Delete obsolete log4j config	5 years ago
spring-jcl	Polishing	5 years ago
spring-jdbc	Clarify JDBC-defined negative values returned from batchUpdate	5 years ago
spring-jms	Use autoboxing instead of explicit wrapping in tests	5 years ago
spring-messaging	Consistent not-null assertions for configured interceptors	5 years ago
spring-orm	Consistently refer to FlushMode.MANUAL instead of outdated NEVER	5 years ago
spring-oxm	Use SingletonSupplier for XStream instance in XStreamMarshaller	5 years ago
spring-test	Polishing	5 years ago
spring-tx	Consistently refer to FlushMode.MANUAL instead of outdated NEVER	5 years ago
spring-web	Polishing	5 years ago
spring-webflux	Polishing	5 years ago
spring-webmvc	Pre-calculated RequestMappingInfo hashcode	5 years ago
spring-websocket	Extend readOnlyWebSocketHttpHeaders deprecation to 5.1.16	5 years ago
src	Support for shared GroovyClassLoader in GroovyScriptFactory	5 years ago
.editorconfig	Add EditorConfig	8 years ago
.gitattributes	Ensure line endings for binary files are not modified in Git	5 years ago
.gitignore	Rename non-Framework project modules	5 years ago
.mailmap	Change gopivotal.com to pivotal.io	10 years ago
CODE_OF_CONDUCT.adoc	URL Cleanup	6 years ago
CONTRIBUTING.md	Update StackOverflow link	5 years ago
LICENSE.txt	Add LICENSE.txt file	5 years ago
README.md	Fix grammar	5 years ago
SECURITY.md	Create SECURITY.md	6 years ago
build.gradle	Upgrade to Jetty Reactive HttpClient 1.1.3	5 years ago
gradle.properties	Next Development Version	5 years ago
gradlew	Upgrade to Gradle 5.6	5 years ago
gradlew.bat	Revert "Upgrade to Gradle 5.6.3"	5 years ago
import-into-eclipse.md	Polishing regarding AJDT versions	5 years ago
import-into-idea.md	URL Cleanup	6 years ago
settings.gradle	Unpublish Gradle metadata	5 years ago

README.md

Spring Framework

This is the home of the Spring Framework: the foundation for all Spring projects. Collectively the Spring Framework and the family of Spring projects are often referred to simply as "Spring".

Spring provides everything required beyond the Java programming language for creating enterprise applications for a wide range of scenarios and architectures. Please read the Overview section as reference for a more complete introduction.

Code of Conduct

This project is governed by the Spring Code of Conduct. By participating, you are expected to uphold this code of conduct. Please report unacceptable behavior to spring-code-of-conduct@pivotal.io.

Access to Binaries

For access to artifacts or a distribution zip, see the Spring Framework Artifacts wiki page.

Documentation

The Spring Framework maintains reference documentation (published and source), Github wiki pages, and an API reference. There are also guides and tutorials across Spring projects.

Build from Source

See the Build from Source Wiki page and the CONTRIBUTING.md file.

Stay in Touch

Follow @SpringCentral, @SpringFramework, and its team members on Twitter. In-depth articles can be found at The Spring Blog, and releases are announced via our news feed.

License

The Spring Framework is released under version 2.0 of the Apache License.