src-spring-framework

Spring Framework

History

rstoyanchev bd66c70b2b Potential fix for flaky STOMP integration tests When ReactorNetty2StompBrokerRelayIntegrationTests fail, typically there are multiple exceptions "Connection refused: /127.0.0.1:61613" that appear after we've conneted, sent CONNECT, and expecting CONNECTED, but that does not come within the 10 second timeout. 61613 is the default port for STOMP. However, in all integration tests we start ActiveMQ with port 0 which results in a random port. Moreover, the stacktrace is for Netty 4 (not 5), and the eventloop thread id's are different than the one where the connection to the correct, random port was established. The suspicion is that these are log messages from MessageBrokerConfigurationTests which focuses on testing configuration but nevertheless as a bean starts and attempts to connect to the default port and fails. Perhaps those attempts to connect on the default port somehow affect the ActiveMQ server, and it stops responding. This change adds a no-op TcpClient in MessageBrokerConfigurationTests to avoid unnecessary attempts to connect that are not needed. See gh-29287	2 years ago
..
src	Potential fix for flaky STOMP integration tests	2 years ago
spring-messaging.gradle	Add native support for RSocketExchange.	2 years ago

rstoyanchev bd66c70b2b Potential fix for flaky STOMP integration tests

When ReactorNetty2StompBrokerRelayIntegrationTests fail, typically there
are multiple exceptions "Connection refused: /127.0.0.1:61613" that
appear after we've conneted, sent CONNECT, and expecting CONNECTED, but
that does not come within the 10 second timeout.

61613 is the default port for STOMP. However, in all integration tests
we start ActiveMQ with port 0 which results in a random port. Moreover,
the stacktrace is for Netty 4 (not 5), and the eventloop thread id's
are different than the one where the connection to the correct, random
port was established.

The suspicion is that these are log messages from
MessageBrokerConfigurationTests which focuses on testing configuration
but nevertheless as a bean starts and attempts to connect to the default
port and fails. Perhaps those attempts to connect on the default port
somehow affect the ActiveMQ server, and it stops responding.

This change adds a no-op TcpClient in MessageBrokerConfigurationTests
to avoid unnecessary attempts to connect that are not needed.

See gh-29287

2 years ago

src

Potential fix for flaky STOMP integration tests

2 years ago

spring-messaging.gradle

Add native support for RSocketExchange.

2 years ago