src-spring-framework

Spring Framework

Tree: 8ac39a50fe

History

Sam Brannen 45a9227047 Remove TODO from AbstractAspectJAdvice Despite the code duplication, we will not delegate to AopUtils.invokeJoinpointUsingReflection() from AbstractAspectJAdvice.invokeAdviceMethodWithGivenArgs(). The rationale is that the exception message in invokeAdviceMethodWithGivenArgs() provides additional context via the pointcut expression, and we would lose that additional context if we simply delegate to AopUtils.invokeJoinpointUsingReflection(). We could introduce an overloaded variant of invokeJoinpointUsingReflection() that accepts an additional argument to provide the additional context for the exception message, but we don't think that would be the best solution for this particular use case. In light of that, we are simply removing the TODO. Closes gh-26126	4 years ago
..
src	Remove TODO from AbstractAspectJAdvice	4 years ago
spring-aop.gradle	…

Sam Brannen 45a9227047 Remove TODO from AbstractAspectJAdvice

Despite the code duplication, we will not delegate to
AopUtils.invokeJoinpointUsingReflection() from
AbstractAspectJAdvice.invokeAdviceMethodWithGivenArgs().

The rationale is that the exception message in
invokeAdviceMethodWithGivenArgs() provides additional context via the
pointcut expression, and we would lose that additional context if we
simply delegate to AopUtils.invokeJoinpointUsingReflection(). We could
introduce an overloaded variant of invokeJoinpointUsingReflection() that
accepts an additional argument to provide the additional context for the
exception message, but we don't think that would be the best solution
for this particular use case.

In light of that, we are simply removing the TODO.

Closes gh-26126

4 years ago

src

Remove TODO from AbstractAspectJAdvice

4 years ago

spring-aop.gradle

…