src-spring-framework

Spring Framework

Tree: e9555d4825

History

Brian Clozel 1960666765 Set error status in Observation Servlet filter Prior to this commit, the Observation Servlet filter would record unhandled exceptions on the observation context but would leave the default HTTP response status as is. Servlet containers do set the response status in that case to 500 by default. Not doing that at the Servlet filter level results in invalid observations, stating that the HTTP response status is 200 (because the error status hasn't been set yet by the container) and as a result, the outcome is SUCCESS. This commit ensures that the error status is set in those cases, aligning the behavior with Servlet containers. Fixes gh-29512	2 years ago
..
src	Set error status in Observation Servlet filter	2 years ago
spring-web.gradle	Upgrade to Reactor 2022.0.0	2 years ago

Brian Clozel 1960666765 Set error status in Observation Servlet filter

Prior to this commit, the Observation Servlet filter would record
unhandled exceptions on the observation context but would leave the
default HTTP response status as is.
Servlet containers do set the response status in that case to 500 by
default. Not doing that at the Servlet filter level results in invalid
observations, stating that the HTTP response status is 200 (because the
error status hasn't been set yet by the container) and as a result, the
outcome is SUCCESS.

This commit ensures that the error status is set in those cases,
aligning the behavior with Servlet containers.

Fixes gh-29512

2 years ago

src

Set error status in Observation Servlet filter

2 years ago

spring-web.gradle

Upgrade to Reactor 2022.0.0

2 years ago